Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary logs #927

Merged
merged 2 commits into from
Dec 15, 2023
Merged

fix: remove unnecessary logs #927

merged 2 commits into from
Dec 15, 2023

Conversation

Aman035
Copy link
Member

@Aman035 Aman035 commented Dec 14, 2023

No description provided.

Copy link

File: packages/restapi/src/lib/alias/getAliasInfo.ts

  • The JSDoc comment above the GetAliasInfoOptionsType type is incorrect. It should be placed after the closing curly brace.
  • The comment on the next line is missing a leading asterisk (*) at the beginning.
  • The comment should be moved inside the function and placed before the return statement.

File: packages/restapi/src/lib/constants.ts

  • The comment above the MessageType enum is missing a leading asterisk (*) at the beginning.
  • The comment should be moved inside the enum and placed before the GIF enum member.
  • The export statement export const PACKAGE_BUILD = packageJson.version.includes('alpha') ? 'ALPHA' : 'STABLE'; is missing a semicolon (;) at the end.

File: packages/restapi/src/lib/pushNotification/pushNotificationBase.ts

  • The closing curly brace } for the fetchUpdateCounter function is missing.
  • The closing parenthesis ) for the throw new Error('Unsupported signer'); statement is missing.
  • The closing curly brace } for the fetchAllownace function is missing.
  • The closing curly brace } for the fetchBalance function is missing.
  • The closing parenthesis ) for the throw new Error(JSON.stringify(error)); statement is missing.
  • The closing curly brace } for the fetchBalance function is missing.

File: packages/restapi/src/lib/video/helpers/sendVideoCallNotification.ts

  • The closing parenthesis ) for the sendNotification function call is missing.
  • The closing curly brace } for the try block is missing.

File: packages/restapi/src/lib/userLowLevel/createUserWithProfile.test.ts

  • The import statement for CONSTANTS is incorrect. It should import from '../../../src/lib/constants' instead of '../../../src/lib/constantsV2'.
  • The comment above the pushProfileV3 test case is incorrect. It should be written as 'Push Profile V3' instead of 'Create Push Profile with Profile update'.
  • The comment above the defaultProvider function invocation is missing a space between ethers.getDefaultProvider and (5).
  • The comment above the walletAddress variable assignment is missing a semicolon (;) at the end.
  • The comment above the account variable assignment is missing a semicolon (;) at the end.
  • The expect assertion for user.encryptedPrivateKey is missing a closing parenthesis ) at the end.
  • The expect assertion for user.profile.picture is missing a closing parenthesis ) at the end.
  • The closing curly brace } for the pushProfileV3 test case is missing.

All looks good.

@Aman035 Aman035 linked an issue Dec 14, 2023 that may be closed by this pull request
Copy link

File: packages/restapi/src/lib/alias/getAliasInfo.ts

  • There is a missing closing } for the GetAliasInfoOptionsType type declaration. Add } at the end.
  • The comment before the function getAliasInfo is not properly formatted. Remove the * at the beginning of the comment.

File: packages/restapi/src/lib/video/helpers/sendVideoCallNotification.ts

  • The line const approvalTrxPromise = contract!['approve'](spenderAddress, amount); is duplicated. Remove one of them.

File: packages/restapi/tests/lib/userLowLevel/createUserWithProfile.test.ts

  • There is a missing closing } at the end of the test case. Add } at the end.

@Aman035 Aman035 merged commit c717303 into main Dec 15, 2023
1 check passed
@Aman035 Aman035 deleted the remove-logs branch December 15, 2023 06:47
@@ -69,7 +60,6 @@ export async function join(this: Space) {

// if speaker is pending then approve first or if listner is pending/not found then approve first
if (!isSpeaker && !isListner) {
console.log('CALLING APPROVE');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such good cleanup 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove all occurrences of console.log in the sdk
4 participants