Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove all occurrences of console.log in the sdk #109

Closed
strykerin opened this issue Jan 9, 2023 · 3 comments · Fixed by #927
Closed

remove all occurrences of console.log in the sdk #109

strykerin opened this issue Jan 9, 2023 · 3 comments · Fixed by #927
Assignees
@Aman035 @madhur-push
Milestone
Push Optimisation...

Comments

@strykerin
Copy link
Contributor

No description provided.

@dawsbot
Copy link

dawsbot commented Feb 1, 2023

Would LOVE to see this implemented @strykerin. Seeing the massive volume of logging for each request pushed is crushing our applications over on @BanklessLabs 🙏

Logging hurts performance heavily on big scripts, which we run daily for Earnifi

@dawsbot
Copy link

dawsbot commented Feb 8, 2023

Any updates on this one? Earnifi by Bankless is crushing under the rerendering lag from all these logs @ethereum-push-notification-service @mishramonalisha76 @0xNilesh

@HarshRajat HarshRajat added this to the Push SDK V1.6 milestone Nov 27, 2023
@Aman035 Aman035 linked a pull request Dec 14, 2023 that will close this issue
fix: remove unnecessary logs #927
Merged
@dawsbot
Copy link

dawsbot commented Dec 19, 2023

Wahoo! Thanks @Aman035 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aman035 Aman035

@madhur-push madhur-push

Labels
None yet
Projects
None yet
Milestone
Push Optimisations V1.6
Development

Successfully merging a pull request may close this issue.

fix: remove unnecessary logs push-protocol/push-sdk
5 participants
@dawsbot @strykerin @HarshRajat @Aman035 @madhur-push