Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ethers optional #1129

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Mark ethers optional #1129

merged 3 commits into from
Feb 28, 2024

Conversation

Aman035
Copy link
Member

@Aman035 Aman035 commented Feb 28, 2024

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

In the packages/restapi/README.md file:

  • Typo: @pushprotocol/restapi@latest, "latest" should not be preceded with '@'.
  • Typo: "To approve a space request" should be "To approve a space request".
  • Typo: "Disconnect an ongoing video call", "an-ongoing" should be "an ongoing".
  • Typo: "Request a Video Call", "a-video-call" should be "a video call".
  • Typo: "Reject an incoming Video Call", "a-incoming" should be "an incoming".
  • Typo: "Manage Media Config", "Manage" should be "Managing".
  • Typo: "Fecthing list of user spaces", "Fecthing" should be "Fetching".
  • Typo: "Fecthing list of user space requests", "Fecthing" should be "Fetching".

In the packages/restapi/package.json file:

  • There are multiple typos and formatting issues. Please revise the structure of the JSON file to be correct.
  • Missing closing curly braces in the peerDependencies and dependencies objects.

In the packages/restapi/src/lib/helpers/signer.ts file:

  • Missing closing curly brace for the signTypedData method definition.

In the packages/restapi/src/lib/pushNotification/pushNotificationBase.ts file:

  • Typo: "ROLEL_TYPE" should be "RANGE_TYPE".
  • Typo: "LENGTH_LOWER_LIMTI" should be "LENGTH_LOWER_LIMIT".
  • Typo: "constructor(signer: SignerType)" missing closing curly brace.
  • Typo: validateCAIP(address) should be validateCAIP(address).
  • Formatting issues in the getChannelOrAliasInfo method.
  • Typo: Missing closing curly brace after the getChannelOrAliasInfo method.

Please correct these issues and re-check after the revisions.

@Aman035 Aman035 linked an issue Feb 28, 2024 that may be closed by this pull request
@Aman035 Aman035 merged commit 2cd3771 into main Feb 28, 2024
2 checks passed
@Aman035 Aman035 deleted the mark-ethers-optional branch March 6, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😈 [Improvement Proposal] - Remove ethers as a peer dependency
2 participants