Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

😈 [Improvement Proposal] - Remove ethers as a peer dependency #1117

Closed
Aman035 opened this issue Feb 20, 2024 · 0 comments · Fixed by #1129
Closed

😈 [Improvement Proposal] - Remove ethers as a peer dependency #1117

Aman035 opened this issue Feb 20, 2024 · 0 comments · Fixed by #1129
Assignees
@Aman035

Comments

@Aman035
Copy link
Member

Aman035 commented Feb 20, 2024

Proposal name

Remove ethers as a peer dependency

Describe the Proposal

Push-sdk has shifted to viem for most of the internal fns but ethers still remain as a peer dependency.
This makes the Push-sdk more bulky. Removing this peer dependency can optiimize size a lot.

Use Case

Current Limitations
@Aman035 Aman035 self-assigned this Feb 20, 2024
@Aman035 Aman035 linked a pull request Feb 28, 2024 that will close this issue
Mark ethers optional #1129
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aman035 Aman035

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark ethers optional push-protocol/push-sdk
1 participant
@Aman035