tc_sram: Remove 'X initialization for SimInit = "none"
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks to me like this PR is implementing the same behavior as #23. However, having the if condition within the always_ff block makes the tc_sram no longer synthesizable nor verilatable. Right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes any form of initialization for the sram simulation in case the default "none" is set for SimInit. This allows for memory initialization from a tb by hierarchically accessing the module in an initial block, as is done in HERO, see also pulp-platform/hero@c88efca. In case this is not done, the default behavior should not change drastically, as the initial value will still be
'X, however will not be reset on rst_ni. If the current behavior is desired, a value other than "none", "zeros", "ones", or "random" should be set for SimInit.