Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hw: Fix memory consistency between int and FP datapaths #90

Merged
merged 11 commits into from
Mar 4, 2024
Merged

Conversation

paulsc96
Copy link
Collaborator

@paulsc96 paulsc96 commented Feb 8, 2024

ToDo:

  • Handle CC parametric cases and non-FPU case (no CAQ needed)
  • Basic debug in simulation
  • Get all CI tests to run correctly (all except one pass: openmp_for_static_schedule fixed)
  • Mind atomics: RMW "reads" must collide in CAQ!
  • Add isochronous crossing to FPSS response channel (oops)
  • Create minimal added test caq.c validating race fix
  • Prevent multiple responses in FREP
  • Add test for FREP fix
  • Choose sensible defaults for parameters: need to avoid FREP performance issues -> Depth 8, Tag width 16
  • Ensure failure of caq.c, caq_frep.c on prior system
  • Verify internal exploration benchmarks
  • Remove broken flashattention_2
  • Fix Verilator tests in Docker container
  • Resolve TODOs in RTL:
    • Are exceptions safe? (They should be)
    • Should response be default-cut for timing?
    • Can/should we respond on issue to save response RTT on collision?
  • Evaluate area, timing synthesis and any degradations in implementation --> Future ToDo

@paulsc96 paulsc96 changed the title hw: Fix load-store consistency between int and FP datapaths hw: Fix memory consistency between int and FP datapaths Feb 8, 2024
@paulsc96 paulsc96 force-pushed the paulsc/caq branch 8 times, most recently from 476442f to 5ad46dd Compare February 9, 2024 22:20
@paulsc96 paulsc96 marked this pull request as ready for review February 13, 2024 13:34
@paulsc96 paulsc96 force-pushed the paulsc/caq branch 8 times, most recently from 3be6996 to 8023e8b Compare February 15, 2024 00:25
@viv-eth viv-eth force-pushed the paulsc/caq branch 2 times, most recently from db600d2 to 5c2b084 Compare February 16, 2024 14:22
@colluca colluca force-pushed the paulsc/caq branch 3 times, most recently from 0db90b2 to e23dee9 Compare February 27, 2024 10:48
@viv-eth viv-eth mentioned this pull request Feb 27, 2024
@colluca colluca merged commit 1a0ff31 into main Mar 4, 2024
27 checks passed
@colluca colluca deleted the paulsc/caq branch March 4, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants