-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sw: Restructuring of BLAS and DNN kernels #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
viv-eth
force-pushed
the
dnn-additions
branch
19 times, most recently
from
June 19, 2024 12:37
016eb62
to
da74393
Compare
fischeti
changed the title
[DRAFT] Restructering of BLAS and DNN kernels
sw: Restructuring of BLAS and DNN kernels
Jun 20, 2024
fischeti
reviewed
Jun 20, 2024
target/snitch_cluster/sw/apps/dnn/flashattention_2/tcasai/cfg/fp16-opt-gpt-3-xl-inf.json
Outdated
Show resolved
Hide resolved
target/snitch_cluster/sw/apps/dnn/flashattention_2/tcasai/cfg/fp16-opt-gpt-j-inf.json
Outdated
Show resolved
Hide resolved
viv-eth
force-pushed
the
dnn-additions
branch
2 times, most recently
from
June 28, 2024 14:03
390ef52
to
8ecb9e6
Compare
[sw] FCL: fix struct declaration
[lint] FA-2 FP8 and GEMM
FA-2: add transpose header first ci: add FA-2 kernel due to header include order
[sw] FCL: fix struct declaration
colluca
approved these changes
Jul 4, 2024
colluca
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will introduce substantial changes to the SW library in the BLAS and DNN kernels.
GEMM
This PR comprises the following changes in the BLAS library:
impl
function that will fetch the correct kernel from theconfig.json
file. All of this is wrapped inside agemm_args_t
struct that holds all kernel-related data. The arguments in the struct are loaded into the cluster's TCDM to avoid costly DRAM accesses when calling the function. The roadmap is to adapt all kernels in thesw
library to this format to improve performance.datagen
script of unsupported or invalid configurations with the relevant error messages.fused_concat_linear
to the new layout.FlashAttention-2
Treewide
This PR also includes some treewide changes.
Remove all math library related sources, which are no longer needed after hw: Fix memory consistency between int and FP datapaths #90.
Remove all uses of the
$PYTHON
environment variable, and instead consistently rely on shebang directives to pick up the active virtual environment'spython
executable.