hw: Replace non-resettable FFs #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fischeti
force-pushed
the
non-rst-ffs
branch
2 times, most recently
from
23a0335 to
c619022
Compare
fischeti
force-pushed
the
non-rst-ffs
branch
2 times, most recently
from
5de3bcf to
39fd927
Compare
fischeti
requested review from
paulsc96,
lucabertaccini and
colluca
as code owners
colluca
requested changes
Jul 19, 2024
hw/snitch_ipu/src/snitch_int_ss.sv
Outdated
| @@ -601,20 +601,21 @@ module snitch_int_ss import riscv_instr::*; import snitch_ipu_pkg::*; import sni | |||
| ); | |||
|
|
|||
| for (genvar i = 0; i < 2; i++) begin : gen_multi_cycle_buffer | |||
| `FFLNR(imd_val_q[i], imd_val_q[i], imd_val_we[i], clk_i) | |||
| `FFL(imd_val_q[i], imd_val_q[i], imd_val_we[i], '0, clk_i, rst_i) | |||
There was a problem hiding this comment.
As an active-low FF, this should use rst_ni, or be changed to `FFLAR. Please double-check everywhere that `FFL gets an active-low reset, and viceversa.
There was a problem hiding this comment.
Good catch, thanks! I double-checked everything else again.
colluca
approved these changes
Jul 19, 2024
This was referenced Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all non-resettable FlipFlops with resettable ones. Non-resettable FlipFlops have a marginally smaller area but can cause undefined behavior, and the common agreement is that non-resettable FlipFlops should be replaced everywhere if possible.
This PR also replaces all deprecated macros e.g.
FFARNwithFF, and adapts the parameters in thesnitch_regfilemodules to the CamelCase naming convention.TODO