-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 32bit scale #5
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1d2f45e
Fix functional model saturating casts and add more intermediate resul…
lukamac faadd4e
Fix global_shift calculation
lukamac dfe0c4f
Add tests with 32bit scale
lukamac 6b0c166
Fix formatting
lukamac bb875a3
Updated changelog
lukamac 1fed889
Updated accelerator features
lukamac File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
{ | ||
"in_height": 3, | ||
"in_width": 3, | ||
"in_channel": 2, | ||
"out_channel": 2, | ||
"padding": { | ||
"top": 0, | ||
"bottom": 0, | ||
"left": 0, | ||
"right": 0 | ||
}, | ||
"kernel_shape": { | ||
"height": 1, | ||
"width": 1 | ||
}, | ||
"depthwise": false, | ||
"stride": { | ||
"height": 1, | ||
"width": 1 | ||
}, | ||
"in_type": "int8", | ||
"out_type": "int8", | ||
"weight_type": "int8", | ||
"scale_type": "uint32", | ||
"bias_type": "int32", | ||
"has_norm_quant": true, | ||
"has_bias": true, | ||
"has_relu": false | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
{ | ||
"in_height": 10, | ||
"in_width": 10, | ||
"in_channel": 10, | ||
"out_channel": 10, | ||
"padding": { | ||
"top": 0, | ||
"bottom": 0, | ||
"left": 0, | ||
"right": 0 | ||
}, | ||
"kernel_shape": { | ||
"height": 1, | ||
"width": 1 | ||
}, | ||
"depthwise": false, | ||
"stride": { | ||
"height": 1, | ||
"width": 1 | ||
}, | ||
"in_type": "uint8", | ||
"out_type": "int8", | ||
"weight_type": "int8", | ||
"scale_type": "uint32", | ||
"bias_type": "int32", | ||
"has_norm_quant": true, | ||
"has_bias": true, | ||
"has_relu": false | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
{ | ||
"in_height": 10, | ||
"in_width": 10, | ||
"in_channel": 128, | ||
"out_channel": 128, | ||
"padding": { | ||
"top": 0, | ||
"bottom": 0, | ||
"left": 0, | ||
"right": 0 | ||
}, | ||
"kernel_shape": { | ||
"height": 1, | ||
"width": 1 | ||
}, | ||
"depthwise": false, | ||
"stride": { | ||
"height": 1, | ||
"width": 1 | ||
}, | ||
"in_type": "uint8", | ||
"out_type": "int8", | ||
"weight_type": "int8", | ||
"scale_type": "uint32", | ||
"bias_type": "int32", | ||
"has_norm_quant": true, | ||
"has_bias": true, | ||
"has_relu": false | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove
uint16
actually... even if it's there in HWThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like completely remove
mode16
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I refer specifically to the scaling option. Not to the full support for 16-bits inputs.