Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 32bit scale #5

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Fix 32bit scale #5

merged 6 commits into from
Feb 16, 2024

Conversation

lukamac
Copy link
Collaborator

@lukamac lukamac commented Feb 13, 2024

No description provided.

@lukamac lukamac self-assigned this Feb 13, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove uint16 actually... even if it's there in HW

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like completely remove mode16?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refer specifically to the scaling option. Not to the full support for 16-bits inputs.

Copy link
Member

@FrancescoConti FrancescoConti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukamac lukamac merged commit b4d7cd4 into main Feb 16, 2024
2 checks passed
@lukamac lukamac deleted the fix-32bit-scale branch February 16, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants