-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hw: Disable AXI splitting checks in AXI-RT #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please
- Extend the Xilinx top wrapper, since this parameter has a nonzero default. On that note, maybe it is better to invert the parameter to an enable semantic if erroneously enabling these checks is considered a bug.
- Amend the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as Paul, for the rest LGTM
Enabling it is not a bug. The current parameter solution should be seen as a temporary solution that will eventually be replaced when redesigning the burst splitter. The new parameter defaults to 0, no changes are required to the xilinx wrapper. |
f9ba14e
to
eb0df30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This addresses one point in #4 of AXI-RT.