Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put vcs and vsim defines in quotes #168

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Put vcs and vsim defines in quotes #168

merged 1 commit into from
Apr 29, 2024

Conversation

SamuelRiedel
Copy link
Member

Fixes #162

@SamuelRiedel SamuelRiedel requested a review from micprog April 22, 2024 09:36
micprog
micprog approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@micprog micprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@micprog micprog merged commit 765720e into master Apr 29, 2024
6 checks passed
@micprog micprog deleted the fix-vcs-defines branch April 29, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micprog micprog micprog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Defines assumed to be string values, not numerical values
2 participants
@SamuelRiedel @micprog