Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HW] Iteration_cnt_d should update when result_queue not full #375

Closed
wants to merge 2 commits into from

Conversation

wayne-win
Copy link

@wayne-win wayne-win commented Nov 24, 2024

Description of PR that completes issue here...

Changelog

Fixed

  • iteration_cnt_d should update only when result_queue is not full, or the result for vid operation will miss since the queue is not ready.

Added

  • Description of changes

Changed

  • Description of changes

Checklist

  • Automated tests pass
  • Changelog updated
  • Code style guideline is observed

Please check our contributing guidelines before opening a Pull Request.

@wayne-win wayne-win requested a review from mp-17 as a code owner November 24, 2024 12:18
@wayne-win wayne-win changed the title iteration_cnt_d should update when result_queue not full [HW] iteration_cnt_d should update when result_queue not full Nov 25, 2024
@wayne-win wayne-win changed the title [HW] iteration_cnt_d should update when result_queue not full [HW] Iteration_cnt_d should update when result_queue not full Nov 25, 2024
@mp-17
Copy link
Collaborator

mp-17 commented Nov 25, 2024

Hi @wayne-win, thanks a lot for the contribution. I am currently refactoring the MASKU here, and this and other bugs should be solved by this refactoring.

@wayne-win wayne-win closed this by deleting the head repository Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants