Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hardware] 🐛 Fix alu reduction race condition #352

Merged
merged 1 commit into from
Aug 29, 2024
Merged

[hardware] 🐛 Fix alu reduction race condition #352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hardware/src/lane/valu.sv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,7 @@ module valu import ara_pkg::*; import rvv_pkg::*; import cf_math_pkg::idx_width;
if ((vinsn_queue_d.issue_cnt == '0) && !prevent_commit) begin
// INTRA_LANE_REDUCTION state needs the result queue
// Start the reduction only if the commit queue (so, the result queue, too) is empty
alu_state_d = is_reduction(vfu_operation_i.op) && (commit_cnt_q == '0) ? INTRA_LANE_REDUCTION : NO_REDUCTION;
alu_state_d = is_reduction(vfu_operation_i.op) && (vinsn_queue_d.commit_cnt == '0) ? INTRA_LANE_REDUCTION : NO_REDUCTION;
// The next will be the first operation of this instruction
// This information is useful for reduction operation
// Initialize reduction-related sequential elements
Expand Down
Loading