Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HW] 🐛 Bug fixes #308

Merged
merged 14 commits into from
Jun 28, 2024
Merged

[HW] 🐛 Bug fixes #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8d4fd75
Rename CSRs in ara dispatcher
MaistoV Jun 19, 2024
9591d0d
Stall Ara upon operations on vector CSRs
MaistoV Jun 19, 2024
54f49b4
[hardware] :bug: Wait full idle before reading the CSRs
mp-17 Jun 27, 2024
908416c
Change "errors" to "exceptions"
MaistoV Jun 19, 2024
aa4320b
Extend and fix Ara exception reporting from VLSU
MaistoV Jun 19, 2024
31c50f8
Set vstart=0 for succesful vector instructions
MaistoV Jun 19, 2024
68f3a87
[hardware] Fix vstart handling in dispatcher
mp-17 Jun 19, 2024
259fcae
[hardware] :bug: Fix reshuffling bug in dispatcher
mp-17 Dec 19, 2023
5128727
[hardware] :bug: Fix eew_q update during reshuffle
mp-17 Mar 10, 2024
64f19e5
[hardware] :bug: Suboptimal fix to reshuffle with LMUL > 1
mp-17 Mar 10, 2024
e34a24d
[hardware] :bug: Fix reshuffle
mp-17 Mar 12, 2024
f302889
[hardware] :bug: Consider LMUL when deciding if to reshuffle vd
mp-17 Mar 15, 2024
4b5d31a
[hardware] Bump CVA6
mp-17 Jun 19, 2024
e2b474d
[CHANGELOG] Update Changelog
mp-17 Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Bender.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ packages:
Git: https://github.com/pulp-platform/common_verification.git
dependencies: []
cva6:
revision: ee89dcc00e6c1a1f4cf97ee1835e950fcfdeebb5
revision: ea86d0ac5fe23ac7889cf8a8b8df7a8c0813bfad
version: null
source:
Git: https://github.com/pulp-platform/cva6.git
Git: https://github.com/mp-17/cva6.git
dependencies:
- axi
- common_cells
Expand Down
2 changes: 1 addition & 1 deletion Bender.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ package:
dependencies:
axi: { git: "https://github.com/pulp-platform/axi.git", version: 0.39.1 }
common_cells: { git: "https://github.com/pulp-platform/common_cells.git", version: 1.22.1 }
cva6: { git: "https://github.com/pulp-platform/cva6.git", rev: ee89dcc00e6c1a1f4cf97ee1835e950fcfdeebb5 } # pulp-v1
cva6: { git: "https://github.com/mp-17/cva6.git", rev: ea86d0ac5fe23ac7889cf8a8b8df7a8c0813bfad } # rebase/pulp-v1-os
tech_cells_generic: { git: "https://github.com/pulp-platform/tech_cells_generic.git", version: 0.2.13 }
apb: { git: "https://github.com/pulp-platform/apb.git", version: 0.2.4 }

Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

- Fix dump vtrace script for vsetvli instructions without x0 (ideal dispatcher)
- Fix Pathfinder and FFT performance
- Stall Ara and wait for ara_idle upon CSR write/read
- Fix how VLSU reports exceptions
- Set vstart=0 upon succesfull vector instructions
- Fix vstart usage in ara dispatcher
- Fix reshuffle mechanism

### Added

Expand All @@ -30,6 +35,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- [f]dotproduct works on the vector length in elements
- Optimize DWT
- Fix pathfinder performance
- Rename CSRs in dispatcher to improve clarity
- Change from reporting "errors" to full "exceptions"
- Bump CVA6 to version that supports "exceptions" reporting

## 3.0.0 - 2023-09-08

Expand Down
6 changes: 3 additions & 3 deletions hardware/include/ara_pkg.sv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,11 +324,11 @@ package ara_pkg;
// Scalar response
elen_t resp;

// Instruction triggered an error
logic error;
// Instruction triggered an exception
ariane_pkg::exception_t exception;

// New value for vstart
vlen_t error_vl;
vlen_t exception_vstart;
} ara_resp_t;

////////////////////
Expand Down
12 changes: 6 additions & 6 deletions hardware/src/ara.sv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ module ara import ara_pkg::*; #(
pe_resp_t [NrPEs-1:0] pe_resp;
// Interface with the address generator
logic addrgen_ack;
logic addrgen_error;
vlen_t addrgen_error_vl;
ariane_pkg::exception_t addrgen_exception;
vlen_t addrgen_exception_vstart;
logic [NrLanes-1:0] alu_vinsn_done;
logic [NrLanes-1:0] mfpu_vinsn_done;
// Interface with the operand requesters
Expand Down Expand Up @@ -171,8 +171,8 @@ module ara import ara_pkg::*; #(
.pe_scalar_resp_ready_o(pe_scalar_resp_ready ),
// Interface with the address generator
.addrgen_ack_i (addrgen_ack ),
.addrgen_error_i (addrgen_error ),
.addrgen_error_vl_i (addrgen_error_vl )
.addrgen_exception_i (addrgen_exception ),
.addrgen_exception_vstart_i(addrgen_exception_vstart )
);

// Scalar move support
Expand Down Expand Up @@ -337,8 +337,8 @@ module ara import ara_pkg::*; #(
.pe_req_ready_o (pe_req_ready[NrLanes+OffsetStore : NrLanes+OffsetLoad]),
.pe_resp_o (pe_resp[NrLanes+OffsetStore : NrLanes+OffsetLoad] ),
.addrgen_ack_o (addrgen_ack ),
.addrgen_error_o (addrgen_error ),
.addrgen_error_vl_o (addrgen_error_vl ),
.addrgen_exception_o (addrgen_exception ),
.addrgen_exception_vstart_o (addrgen_exception_vstart ),
// Interface with the Mask unit
.mask_i (mask ),
.mask_valid_i (mask_valid ),
Expand Down
Loading
Loading