[cheshire] 🐛 Quote variables in Makefile

pulp-platform · Oct 19, 2024 · 066896a · 066896a
1 parent 8f7c121
commit 066896a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/cheshire/Makefile b/cheshire/Makefile
@@ -39,10 +39,10 @@ ara-chs-image:
 	make -C $(BACKREF_CHS_ROOT) $(BACKREF_CHS_ROOT)/sw/boot/linux.$(BOARD).gpt.bin -B
 
 ara-chs-xilinx-flash:
-	make -C $(BACKREF_CHS_ROOT) chs-xilinx-flash-$(BOARD) VIVADO=$(VIVADO) CHS_XILINX_HWS_URL=$(CHS_XILINX_HWS_URL) CHS_XILINX_HWS_PATH_$(BOARD)=$(CHS_XILINX_HWS_PATH)
+	make -C $(BACKREF_CHS_ROOT) chs-xilinx-flash-$(BOARD) VIVADO="$(VIVADO)" CHS_XILINX_HWS_URL="$(CHS_XILINX_HWS_URL)" CHS_XILINX_HWS_PATH_$(BOARD)="$(CHS_XILINX_HWS_PATH)"
 
 ara-chs-xilinx-program:
-	make -C $(BACKREF_CHS_ROOT) chs-xilinx-program-$(BOARD) VIVADO=$(VIVADO) CHS_XILINX_HWS_URL=$(CHS_XILINX_HWS_URL) CHS_XILINX_HWS_PATH_$(BOARD)=$(CHS_XILINX_HWS_PATH)
+	make -C $(BACKREF_CHS_ROOT) chs-xilinx-program-$(BOARD) VIVADO="$(VIVADO)" CHS_XILINX_HWS_URL="$(CHS_XILINX_HWS_URL)" CHS_XILINX_HWS_PATH_$(BOARD)="$(CHS_XILINX_HWS_PATH)"
 
 update_xilinx_src:
 	cd $(BACKREF_CHS_ROOT) && \

diff --git a/cheshire/README.md b/cheshire/README.md
@@ -76,7 +76,6 @@ Note: this script requires `bender`. Also, some Cheshire targets may require an
 
 ```bash
 export CHS_ROOT=$(pwd)/cheshire
-export ARA_ROOT=$(bender -d ${CHS_ROOT} path ara)
 
 # Cheshire commit
 # FILL ME
@@ -104,6 +103,7 @@ git checkout ${CHS_HASH}
 # Checkout Ara
 echo 'Checkout hardware deps'
 bender checkout
+export ARA_ROOT=$(bender -d ${CHS_ROOT} path ara)
 # Compile RVV kernels
 echo 'Install the Linux compiler and compile the LINUX RVV kernels'
 make -C ${ARA_ROOT}/cheshire/sw ${RVV_KERNELS} HOST_TOOLCHAIN_SUFFIX=${HOST_TOOLCHAIN_SUFFIX}