Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-stackdriver-exporter] bump to 0.17.0 #4987

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −4
Open

[prometheus-stackdriver-exporter] bump to 0.17.0 #4987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd5f167
bump to 0.17.0
DrFaust92 Nov 9, 2024
bd52e3b
fix args
DrFaust92 Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/prometheus-stackdriver-exporter/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
apiVersion: v1
description: Stackdriver exporter for Prometheus
name: prometheus-stackdriver-exporter
version: 4.6.2
appVersion: v0.16.0
version: 4.7.0
appVersion: v0.17.0
home: https://www.stackdriver.com/
sources:
- https://github.com/prometheus-community/stackdriver_exporter
Expand Down
4 changes: 2 additions & 2 deletions charts/prometheus-stackdriver-exporter/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,10 @@ spec:
mountPath: /etc/secrets/service-account/
{{- end}}
args:
- --google.project-id={{ .Values.stackdriver.projectId }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make this conditional on appVersion. otherwiese it will be a breakting change.

Copy link

@antoinedeschenes antoinedeschenes Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old flag is still supported, new flag is repeatable, meaning the chart should probably start supporting lists of projectIds and typePrefixes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the "problem" is if someone uses the chart with an older image version it will fail because the old image fails to start. so I would probably add a check for the image version and depending on that adding the flags.

- --google.project-ids={{ .Values.stackdriver.projectId }}
- --monitoring.metrics-interval={{ .Values.stackdriver.metrics.interval }}
- --monitoring.metrics-offset={{ .Values.stackdriver.metrics.offset }}
- --monitoring.metrics-type-prefixes={{ .Values.stackdriver.metrics.typePrefixes | replace " " "" }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here

Copy link

@antoinedeschenes antoinedeschenes Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

- --monitoring.metrics-prefixes={{ .Values.stackdriver.metrics.typePrefixes | replace " " "" }}
{{- range .Values.stackdriver.metrics.filters }}
- --monitoring.filters={{ . }}
{{- end }}
Expand Down
Loading