[prometheus-stackdriver-exporter] bump to 0.17.0 #4987
Conversation
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
| @@ -73,10 +73,10 @@ spec: | |||
| mountPath: /etc/secrets/service-account/ | |||
| {{- end}} | |||
| args: | |||
| - --google.project-id={{ .Values.stackdriver.projectId }} | |||
There was a problem hiding this comment.
can you make this conditional on appVersion. otherwiese it will be a breakting change.
There was a problem hiding this comment.
old flag is still supported, new flag is repeatable, meaning the chart should probably start supporting lists of projectIds and typePrefixes
There was a problem hiding this comment.
the "problem" is if someone uses the chart with an older image version it will fail because the old image fails to start. so I would probably add a check for the image version and depending on that adding the flags.
| - --monitoring.metrics-interval={{ .Values.stackdriver.metrics.interval }} | ||
| - --monitoring.metrics-offset={{ .Values.stackdriver.metrics.offset }} | ||
| - --monitoring.metrics-type-prefixes={{ .Values.stackdriver.metrics.typePrefixes | replace " " "" }} |
There was a problem hiding this comment.
see deprecation notice https://github.com/prometheus-community/stackdriver_exporter/releases/tag/v0.17.0
Deprecation notice: The comma delimited flags
google.project-idandmonitoring.metrics-type-prefixesare being replaced by repeatable flagsgoogle.project-idsandmonitoring.metrics-prefixes. The comma delimited flags will be supported for at least one more release.
| @@ -73,10 +73,10 @@ spec: | |||
| mountPath: /etc/secrets/service-account/ | |||
| {{- end}} | |||
| args: | |||
| - --google.project-id={{ .Values.stackdriver.projectId }} | |||
There was a problem hiding this comment.
old flag is still supported, new flag is repeatable, meaning the chart should probably start supporting lists of projectIds and typePrefixes
| - --monitoring.metrics-interval={{ .Values.stackdriver.metrics.interval }} | ||
| - --monitoring.metrics-offset={{ .Values.stackdriver.metrics.offset }} | ||
| - --monitoring.metrics-type-prefixes={{ .Values.stackdriver.metrics.typePrefixes | replace " " "" }} |
What this PR does / why we need it
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])