Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-blackbox-exporter] Remove toYaml function call in blackbox exporter extra manifests template #4220

Closed
wants to merge 0 commits into from

Conversation

walker-tom
Copy link
Contributor

What this PR does / why we need it

This allows the resources defined via the extraManifests value to have more 'helm-like' layouts when doing templating within them, such as having the template on the line beneath labels below:

extraManifests:
  - apiVersion: v1
     kind: MyCRD
     metadata:
       labels:
         {{- include "prometheus-blackbox-exporter.labels" . | nindent 4 }}

Which issue this PR fixes

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Thanks!

@walker-tom
Copy link
Contributor Author

@dpetersen, @Bregor, @redondos or @grobie, do one of you have the time to review this change please? Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prometheus-blackbox-exporter] include in extra-manifests.yaml
1 participant