Skip to content

Commit

Permalink
Remove toYaml function call in blackbox exporter extra manifests temp…
Browse files Browse the repository at this point in the history
…late

Signed-off-by: Tom Walker <[email protected]>
  • Loading branch information
walker-tom committed Feb 3, 2024
1 parent 21c06e2 commit 1ec1301
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 4 deletions.
2 changes: 1 addition & 1 deletion charts/prometheus-blackbox-exporter/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
description: Prometheus Blackbox Exporter
name: prometheus-blackbox-exporter
version: 8.10.1
version: 9.0.0
appVersion: v0.24.0
home: https://github.com/prometheus/blackbox_exporter
sources:
Expand Down
26 changes: 26 additions & 0 deletions charts/prometheus-blackbox-exporter/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,32 @@ helm upgrade [RELEASE_NAME] [CHART] --install

_See [helm upgrade](https://helm.sh/docs/helm/helm_upgrade/) for command documentation._

### To 9.0.0

This version changes how the value `extraManifests` is used within the [template](./templates/extra-manifests.yaml). It no longer applies the `toYaml` function to each element in the `extraManifests` array. Previously if you used the value to create an extra resource such as:

```yaml
extraManifests:
- apiVersion: v1
kind: ConfigMap
metadata:
name: prometheus-extra
data:
extra-data: "value"
```
This would now need to be a multiline YAML string instead of its own block of YAML:
```yaml
extraManifests:
- |
apiVersion: v1
kind: ConfigMap
metadata:
name: prometheus-extra
data:
extra-data: "value"
```
### To 8.0.0
- The default image is set to `quay.io/prometheus/blackbox-exporter` instead `prom/blackbox-exporter`
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{ range .Values.extraManifests }}
---
{{ tpl (toYaml .) $ }}
{{ tpl . $ }}
{{ end }}
4 changes: 2 additions & 2 deletions charts/prometheus-blackbox-exporter/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -375,10 +375,10 @@ dnsConfig:

# Extra manifests to deploy as an array
extraManifests: []
# - apiVersion: v1
# - |
# apiVersion: v1
# kind: ConfigMap
# metadata:
# labels:
# name: prometheus-extra
# data:
# extra-data: "value"
Expand Down

0 comments on commit 1ec1301

Please sign in to comment.