[prometheus-kafka-exporter] Add nodePort for external use #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joon Seo Kim <[email protected]> Signed-off-by: KimJoonSeo <[email protected]>
Signed-off-by: KimJoonSeo <[email protected]>
zeritti
requested changes
Sep 26, 2023
Thank you for your suggestion! I did commit the change. Co-authored-by: zeritti <[email protected]> Signed-off-by: Joon Seo Kim <[email protected]>
zeritti
approved these changes
Sep 26, 2023
zeritti
changed the title
3 tasks
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
Mar 20, 2024
…-community#3828) * [prometheus-kafka-exporter]: Add nodePort for external use Signed-off-by: Joon Seo Kim <[email protected]> Signed-off-by: KimJoonSeo <[email protected]> * [prometheus-kafka-exporter]: Add nodePort for external use Signed-off-by: KimJoonSeo <[email protected]> * Update charts/prometheus-kafka-exporter/values.yaml Thank you for your suggestion! I did commit the change. Co-authored-by: zeritti <[email protected]> Signed-off-by: Joon Seo Kim <[email protected]> --------- Signed-off-by: Joon Seo Kim <[email protected]> Signed-off-by: KimJoonSeo <[email protected]> Co-authored-by: zeritti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
I added support for the nodePort configuration for external use.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])