Skip to content

Commit

Permalink
[prometheus-kafka-exporter] Add nodePort for external use (prometheus…
Browse files Browse the repository at this point in the history
…-community#3828)

* [prometheus-kafka-exporter]: Add nodePort for external use

Signed-off-by: Joon Seo Kim <[email protected]>
Signed-off-by: KimJoonSeo <[email protected]>

* [prometheus-kafka-exporter]: Add nodePort for external use

Signed-off-by: KimJoonSeo <[email protected]>

* Update charts/prometheus-kafka-exporter/values.yaml

Thank you for your suggestion! I did commit the change.

Co-authored-by: zeritti <[email protected]>
Signed-off-by: Joon Seo Kim <[email protected]>

---------

Signed-off-by: Joon Seo Kim <[email protected]>
Signed-off-by: KimJoonSeo <[email protected]>
Co-authored-by: zeritti <[email protected]>
  • Loading branch information
2 people authored and Matiasmct committed Mar 20, 2024
1 parent 57b676e commit 70e214b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/prometheus-kafka-exporter/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: "v1.7.0"
description: A Helm chart to export the metrics from Kafka in Prometheus format using the kafka-exporter from https://github.com/danielqsj/kafka_exporter
name: prometheus-kafka-exporter
home: https://github.com/danielqsj/kafka_exporter
version: 2.5.0
version: 2.6.0
kubeVersion: ">=1.19.0-0"
sources:
- https://gkarthiks.github.io/helm-charts/charts/prometheus-kafka-exporter
Expand Down
3 changes: 3 additions & 0 deletions charts/prometheus-kafka-exporter/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ spec:
targetPort: exporter-port
protocol: TCP
name: exporter-port
{{- if (and (eq .Values.service.type "NodePort") .Values.service.nodePort) }}
nodePort: {{ .Values.service.nodePort }}
{{- end }}
selector:
app: {{ template "prometheus-kafka-exporter.name" . }}
release: {{ .Release.Name }}
3 changes: 3 additions & 0 deletions charts/prometheus-kafka-exporter/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ service:
port: 9308
labels: {}
annotations: {}
# Specifies a custom nodePort for external use.
# Must be used with service.type=NodePort.
nodePort: null

liveness:
enabled: false
Expand Down

0 comments on commit 70e214b

Please sign in to comment.