Better history API #359
Better history API #359
Conversation
Shatur
force-pushed
the
history-rework
branch
from
78cc506 to
5084f1e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #359 +/- ##
==========================================
+ Coverage 89.93% 90.12% +0.19%
==========================================
Files 44 46 +2
Lines 2484 2563 +79
==========================================
+ Hits 2234 2310 +76
- Misses 250 253 +3 ☔ View full report in Codecov by Sentry. |
Shatur
force-pushed
the
deferred-entity-refactor
branch
from
8799e20 to
941f97b
Compare
Shatur
force-pushed
the
history-rework
branch
from
bc1b7b9 to
e5b3f71
Compare
|
Marking as ready for review. Most added lines are just tests. |
src/client/confirm_history.rs
Outdated
| /// Triggered for an entity when it receives changes for a tick. | ||
| /// | ||
| /// See also [`ConfirmHistory`]. | ||
| #[derive(Debug, Event, Clone, Copy)] | ||
| pub struct HistoryConfirmed { |
There was a problem hiding this comment.
Maybe rename to EntityChanged? The name HistoryConfirmed is confusing to me since you haven't necessarily confirmed anything - there could be more mutation messages for this tick or previous ticks.
There was a problem hiding this comment.
How about EntityReplicated? 🤔 EntityChanged sounds like something from Bevy.
There was a problem hiding this comment.
How about MutateTickConfirmed -> MutateTickReceived as well?
| @@ -366,14 +370,15 @@ fn send_messages( | |||
| trace!("no changes to send for {:?}", client.id()); | |||
| } | |||
|
|
|||
| if !mutate_message.is_empty() { | |||
| if !mutate_message.is_empty() || track_mutate_messages { | |||
There was a problem hiding this comment.
Why do you want to send empty messages? Just to confirm they are empty?
There was a problem hiding this comment.
Yes, necessary to differentiate between missed ticks and ticks without changes.
Implements the proposal from #338:
HistoryConfirmedevent forConfirmHistory.ServerMutateTicksresource that provides an API similar toHistoryConfirmed, but for received mutate messages. To activate it, third-party crate needs to callTrackAppExt::track_mutate_messages. I decided on an app extension method to avoid require user to set it in the plugin. And not via resource since it's something that should be configured before the app starts.MutateTickConfirmedfor the addedServerMutateTicks.Requires #356, I will retarget to the master after the merge.