Bevy 0.15.0 support #341

ironpeak · 2024-10-28T23:27:40Z

Migration to Bevy version 0.15.0-rc.2.

I'll update this PR once the 0.15.0 is out.

README.md

Shatur

Thanks a lot!
Left a few suggestions/questions.

src/core/event_registry/server_event.rs

src/lib.rs

src/server.rs

src/client.rs

codecov · 2024-10-29T03:10:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (a8e10a0) to head (f35def0).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #341   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files          44       44           
  Lines        2486     2487    +1     
=======================================
+ Hits         2234     2235    +1     
  Misses        252      252

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Looks like it should be `PartialReflect` after all: bevyengine/bevy#7207

If someone needs it, it's better to utilize the required components since it's faster.

Shatur · 2024-11-06T23:58:07Z

@UkoeHB I pushed 2 commits (diff) that contain a small breaking change. Please, take a look.
I originally wanted to open a PR for it, but unable to do so because this PR comes from a fork.

UkoeHB · 2024-11-07T00:27:00Z

@UkoeHB I pushed 2 commits (diff) that contain a small breaking change. Please, take a look.

I disagree with not including Replicated on all entities. I use Replicated as a universal marker to clean up entities when exiting a game's state scope. It is much more fragile to manually make sure every entity gets Replicated, and would inevitably lead to entity leaks.

It also permanently couples Replicated with component definitions, which seems unnecessary. It implies all replicated entities need to have some custom component with a #[requires(Replicated)], even if they don't need a custom component for anything.

Shatur · 2024-11-07T10:03:08Z

Good point, I will revert today after work.

This reverts commit 49c5f29.

This reverts commit 586e8e9.

src/lib.rs

Co-authored-by: UkoeHB <[email protected]>

Shatur · 2024-11-29T23:36:34Z

Made a lot of breaking changes in the latest master. I will wait for review for #359 from @UkoeHB and rebase this one after it.

ironpeak · 2024-11-30T00:02:12Z

I merged with master, and created a branch were I tested merging with #359 as well.

All the CI tests are passing:

I also noticed that cargo-deny was failing and updated it to allow Unicode-3.0.

Shatur

Thank you a lot!
I think still merge it after #359, but you saved me a lot of time!

Shatur · 2024-11-30T00:05:51Z

src/server.rs

+            let component: Ptr<'w> = table
+                .get_component(component_id, entity.table_row())
+                .unwrap_unchecked();
+            let ticks = table
+                .get_ticks_unchecked(component_id, entity.table_row())
+                .unwrap_unchecked();


Note to self: I made the fields public in bevyengine/bevy#16269, so it should be possible to create ComponentTicks.

README.md

ironpeak added 3 commits October 28, 2024 20:08

wip

b94a221

fix docs

af80d18

update README

d12bc6f

UkoeHB reviewed Oct 28, 2024

View reviewed changes

README.md Show resolved Hide resolved

Shatur requested changes Oct 29, 2024

View reviewed changes

src/core/event_registry/server_event.rs Show resolved Hide resolved

src/lib.rs Show resolved Hide resolved

src/server.rs Show resolved Hide resolved

Shatur reviewed Oct 29, 2024

View reviewed changes

src/client.rs Outdated Show resolved Hide resolved

PR suggestions from UkoeHB and Shatur

6d407bf

ironpeak force-pushed the master branch from bdde572 to 6d407bf Compare October 29, 2024 10:08

ironpeak and others added 4 commits October 29, 2024 15:50

bevy 0.15

ca56606

Merge remote-tracking branch 'origin/master' into pr/ironpeak/341

caed57d

Update to Bevy 0.15.0-rc.3

64b98c6

Use PartialReflect

9d175e4

Looks like it should be `PartialReflect` after all: bevyengine/bevy#7207

Shatur changed the title ~~Bevy 0.15.0-rc.2~~ Bevy 0.15.0 RC Nov 6, 2024

Shatur added 2 commits November 7, 2024 01:41

Update blueprints section in the quick start guide

586e8e9

Do not insert Replicated on client automatically

49c5f29

If someone needs it, it's better to utilize the required components since it's faster.

Shatur added 3 commits November 7, 2024 18:37

Revert "Do not insert Replicated on client automatically"

13a7a27

This reverts commit 49c5f29.

Revert "Update blueprints section in the quick start guide"

acc9a4e

This reverts commit 586e8e9.

Rework blueprints secion

665d086

Shatur requested a review from UkoeHB November 7, 2024 16:37

UkoeHB requested changes Nov 8, 2024

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

src/lib.rs Outdated Show resolved Hide resolved

src/lib.rs Outdated Show resolved Hide resolved

Apply suggestions from code review

ddbe2da

Co-authored-by: UkoeHB <[email protected]>

UkoeHB approved these changes Nov 8, 2024

View reviewed changes

ironpeak added 2 commits November 29, 2024 23:33

0.15

89f7be7

deny toml

a9a276a

ironpeak changed the title ~~Bevy 0.15.0 RC~~ Bevy 0.15.0 support Nov 29, 2024

merge with master

f35def0

Shatur requested changes Nov 30, 2024

View reviewed changes

lubomirkurcak mentioned this pull request Nov 30, 2024

Bevy 0.15 Support Henauxg/bevy_quinnet#30

Closed

Merge remote-tracking branch 'origin/master' into pr/ironpeak/341

67a1be0

UkoeHB approved these changes Dec 1, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

UkoeHB and others added 4 commits December 1, 2024 17:31

Update README.md

dcf2c2e

Merge remote-tracking branch 'origin/master' into pr/ironpeak/341

2d94979

Minor adjustments

f5709da

Add todo comment [skip ci]

732ddb6

Shatur merged commit dcff8b4 into projectharmonia:master Dec 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bevy 0.15.0 support #341

Bevy 0.15.0 support #341

ironpeak commented Oct 28, 2024

Shatur left a comment

codecov bot commented Oct 29, 2024 •

edited

Loading

Shatur commented Nov 6, 2024 •

edited

Loading

UkoeHB commented Nov 7, 2024 •

edited

Loading

Shatur commented Nov 7, 2024

Shatur commented Nov 29, 2024

ironpeak commented Nov 30, 2024

Shatur left a comment

Shatur Nov 30, 2024 •

edited

Loading

Bevy 0.15.0 support #341

Bevy 0.15.0 support #341

Conversation

ironpeak commented Oct 28, 2024

Shatur left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 29, 2024 • edited Loading

Codecov Report

Shatur commented Nov 6, 2024 • edited Loading

UkoeHB commented Nov 7, 2024 • edited Loading

Shatur commented Nov 7, 2024

Shatur commented Nov 29, 2024

ironpeak commented Nov 30, 2024

Shatur left a comment

Choose a reason for hiding this comment

Shatur Nov 30, 2024 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Oct 29, 2024 •

edited

Loading

Shatur commented Nov 6, 2024 •

edited

Loading

UkoeHB commented Nov 7, 2024 •

edited

Loading

Shatur Nov 30, 2024 •

edited

Loading