Rework DeferredEntity creation
#356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #356 +/- ##
==========================================
- Coverage 89.71% 89.69% -0.03%
==========================================
Files 44 44
Lines 2450 2445 -5
==========================================
- Hits 2198 2193 -5
Misses 252 252 ☔ View full report in Codecov by Sentry. |
Shatur
force-pushed
the
deferred-entity-refactor
branch
4 times, most recently
from
c79c770 to
8799e20
Compare
Merged
I realized that it's possible to construct commands from the entity's world. It lets me hide all unsafety in the constructor and re-use it in other places.
Shatur
force-pushed
the
deferred-entity-refactor
branch
from
8799e20 to
941f97b
Compare
|
Re-targeted to the lastest master. |
UkoeHB
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that it's possible to construct commands from the entity's world.
It lets me hide all unsafety in the constructor and re-use it in other places.
Requires #352, I will retarget to the master after the merge.