Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vercel deploy in github actions #75

Merged
merged 13 commits into from
Nov 29, 2023
Merged

Add vercel deploy in github actions #75

merged 13 commits into from
Nov 29, 2023

Conversation

foyarash
Copy link
Collaborator

#72

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 23, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: aead758

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

tlenclos
tlenclos reviewed Nov 29, 2023
View reviewed changes
apps/example/prisma/schema.prisma
@@ -2,7 +2,8 @@
// learn more about it in the docs: https://pris.ly/d/prisma-schema

generator client {
provider = "prisma-client-js"
provider = "prisma-client-js"
binaryTargets = ["native", "rhel-openssl-1.0.x"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
binaryTargets = ["native", "rhel-openssl-1.0.x"]
binaryTargets = ["native", "rhel-openssl-1.0.x"]

Why this modification ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had an issue related to build being done on a different environment than vercel

Query engine library for current platform "rhel-openssl-1.1.x" could not be found.

@foyarash foyarash merged commit 561f37a into main Nov 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlenclos tlenclos tlenclos left review comments

@cregourd cregourd cregourd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foyarash @tlenclos @cregourd