fix: crash on undefined relationship length (#467)

* fix: crash on undefined relationship length * add optional operator in fillRelationInSchema
premieroctet · Oct 4, 2024 · c25f61c · c25f61c
1 parent 3bfa1a1
commit c25f61c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/metal-ties-help.md b/.changeset/metal-ties-help.md
@@ -0,0 +1,5 @@
+---
+"@premieroctet/next-admin": patch
+---
+
+fix: crash on undefined relationship length (#465)
diff --git a/packages/next-admin/src/utils/server.ts b/packages/next-admin/src/utils/server.ts
@@ -252,7 +252,7 @@ export const fillRelationInSchema =
         if (fieldKind === "object") {
           const modelNameRelation = fieldType as ModelName;
 
-          if (relationToFields!.length > 0) {
+          if (relationToFields?.length) {
             //Relation One-to-Many, Many side
             const enumeration: Enumeration[] = [];
             schema.definitions[modelName].properties[fieldName] = {
@@ -439,8 +439,8 @@ export const findRelationInData = (
        * because one side of a one-to-one relation will not have relationFromFields
        */
       if (
-        (dmmfPropertyRelationFromFields!.length > 0 &&
-          dmmfPropertyRelationToFields!.length > 0) ||
+        (dmmfPropertyRelationFromFields?.length &&
+          dmmfPropertyRelationToFields?.length) ||
         !dmmfProperty.isList
       ) {
         const idProperty = getModelIdProperty(dmmfProperty.type as ModelName);