Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate click pip dependency #573

Merged
merged 4 commits into from
Dec 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions .github/actions/setup-apt/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,9 @@ runs:
- name: Install base packages
shell: bash
run: |
${{ inputs.sudo }} apt-get install python3-venv python3-pip make -y
${{ inputs.sudo }} apt-get install make gcc python3 -y
- name: Install additional packages
if: ${{ inputs.packages != ''}}
shell: bash
run: |
${{ inputs.sudo }} apt-get install ${{ inputs.packages }} -y
- name: Setup Python venv
shell: bash
run: |
python3 -m venv venv
source venv/bin/activate
python3 -m pip install -r requirements.txt
deactivate
echo "$(pwd)/venv/bin/" >> "$GITHUB_PATH"
10 changes: 1 addition & 9 deletions .github/actions/setup-yum/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,9 @@ runs:
- name: Install base packages
shell: bash
run: |
${{ inputs.sudo }} yum install make git python3-pip -y
${{ inputs.sudo }} pip3 install virtualenv
${{ inputs.sudo }} yum install make gcc python3 git -y
- name: Install additional packages
if: ${{ inputs.packages != ''}}
shell: bash
run: |
${{ inputs.sudo }} yum install ${{ inputs.packages }} -y
- name: Setup Python venv
shell: bash
run: |
virtualenv venv
source venv/bin/activate
python3 -m pip install -r requirements.txt
echo "$(pwd)/venv/bin/" >> "$GITHUB_PATH"
6 changes: 1 addition & 5 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,4 @@ updates:
directory: /
schedule:
interval: monthly

- package-ecosystem: pip
directory: /
schedule:
interval: monthly

9 changes: 1 addition & 8 deletions BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,7 @@

### Prerequisites

To build **mlkem-native**, you need `make` and a C90 compiler. To use the test scripts, you need Python3 with
dependencies as specified in [requirements.txt](requirements.txt). We recommend using a virtual environment, e.g.:

```bash
python3 -m venv venv
./venv/bin/python3 -m pip install -r requirements.txt
source venv/bin/activate
```
To build **mlkem-native**, you need `make` and a C90 compiler. To use the test scripts, you need Python3 (>= 3.7).
mkannwischer marked this conversation as resolved.
Show resolved Hide resolved

### Using `make`

Expand Down
7 changes: 1 addition & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,7 @@ cd mlkem-native

# Install base packages
sudo apt-get update
sudo apt-get install python3-venv python3-pip make

# Setup Python environment
python3 -m venv venv
source venv/bin/activate
python3 -m pip install -r requirements.txt
sudo apt-get install make gcc python3

# Build and run base tests
make quickcheck
Expand Down
2 changes: 0 additions & 2 deletions requirements.txt

This file was deleted.

Loading
Loading