-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate click
pip dependency
#573
Conversation
06fe324
to
e953919
Compare
Our test scripts rely on click to argument parsing. This commit removes that dependency and uses the native argparse instead. Signed-off-by: Matthias J. Kannwischer <[email protected]>
e953919
to
3b3ee3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arm Cortex-A76 (Raspberry Pi 5) benchmarks
Benchmark suite | Current: 3b3ee3d | Previous: 84bdac8 | Ratio |
---|---|---|---|
ML-KEM-512 keypair |
29035 cycles |
29017 cycles |
1.00 |
ML-KEM-512 encaps |
35359 cycles |
35398 cycles |
1.00 |
ML-KEM-512 decaps |
45885 cycles |
45885 cycles |
1 |
ML-KEM-768 keypair |
49401 cycles |
49339 cycles |
1.00 |
ML-KEM-768 encaps |
55606 cycles |
55569 cycles |
1.00 |
ML-KEM-768 decaps |
70348 cycles |
70328 cycles |
1.00 |
ML-KEM-1024 keypair |
72061 cycles |
72069 cycles |
1.00 |
ML-KEM-1024 encaps |
80885 cycles |
80844 cycles |
1.00 |
ML-KEM-1024 decaps |
100721 cycles |
100677 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intel Xeon 4th gen (c7i)
Benchmark suite | Current: 3b3ee3d | Previous: 84bdac8 | Ratio |
---|---|---|---|
ML-KEM-512 keypair |
13527 cycles |
13535 cycles |
1.00 |
ML-KEM-512 encaps |
17317 cycles |
17350 cycles |
1.00 |
ML-KEM-512 decaps |
22831 cycles |
22910 cycles |
1.00 |
ML-KEM-768 keypair |
22559 cycles |
22543 cycles |
1.00 |
ML-KEM-768 encaps |
24555 cycles |
24521 cycles |
1.00 |
ML-KEM-768 decaps |
32595 cycles |
32609 cycles |
1.00 |
ML-KEM-1024 keypair |
31463 cycles |
31373 cycles |
1.00 |
ML-KEM-1024 encaps |
34963 cycles |
34925 cycles |
1.00 |
ML-KEM-1024 decaps |
45807 cycles |
45883 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AMD EPYC 3rd gen (c6a)
Benchmark suite | Current: 3b3ee3d | Previous: 84bdac8 | Ratio |
---|---|---|---|
ML-KEM-512 keypair |
18138 cycles |
18138 cycles |
1 |
ML-KEM-512 encaps |
23193 cycles |
23196 cycles |
1.00 |
ML-KEM-512 decaps |
30505 cycles |
30512 cycles |
1.00 |
ML-KEM-768 keypair |
31069 cycles |
31094 cycles |
1.00 |
ML-KEM-768 encaps |
34223 cycles |
34236 cycles |
1.00 |
ML-KEM-768 decaps |
44750 cycles |
44748 cycles |
1.00 |
ML-KEM-1024 keypair |
44599 cycles |
44679 cycles |
1.00 |
ML-KEM-1024 encaps |
49886 cycles |
49901 cycles |
1.00 |
ML-KEM-1024 decaps |
64332 cycles |
64573 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AMD EPYC 4th gen (c7a)
Benchmark suite | Current: 3b3ee3d | Previous: 84bdac8 | Ratio |
---|---|---|---|
ML-KEM-512 keypair |
15068 cycles |
15160 cycles |
0.99 |
ML-KEM-512 encaps |
19671 cycles |
19662 cycles |
1.00 |
ML-KEM-512 decaps |
26290 cycles |
26319 cycles |
1.00 |
ML-KEM-768 keypair |
25558 cycles |
25630 cycles |
1.00 |
ML-KEM-768 encaps |
28143 cycles |
28183 cycles |
1.00 |
ML-KEM-768 decaps |
37817 cycles |
38040 cycles |
0.99 |
ML-KEM-1024 keypair |
35690 cycles |
35601 cycles |
1.00 |
ML-KEM-1024 encaps |
40875 cycles |
40976 cycles |
1.00 |
ML-KEM-1024 decaps |
54474 cycles |
54475 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intel Xeon 3rd gen (c6i)
Benchmark suite | Current: 3b3ee3d | Previous: 84bdac8 | Ratio |
---|---|---|---|
ML-KEM-512 keypair |
20328 cycles |
20325 cycles |
1.00 |
ML-KEM-512 encaps |
27007 cycles |
27001 cycles |
1.00 |
ML-KEM-512 decaps |
35923 cycles |
35822 cycles |
1.00 |
ML-KEM-768 keypair |
34880 cycles |
34883 cycles |
1.00 |
ML-KEM-768 encaps |
38171 cycles |
38178 cycles |
1.00 |
ML-KEM-768 decaps |
50905 cycles |
50920 cycles |
1.00 |
ML-KEM-1024 keypair |
48001 cycles |
47959 cycles |
1.00 |
ML-KEM-1024 encaps |
54159 cycles |
54094 cycles |
1.00 |
ML-KEM-1024 decaps |
71590 cycles |
71687 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intel Xeon 4th gen (c7i) (no-opt)
Benchmark suite | Current: 3b3ee3d | Previous: 84bdac8 | Ratio |
---|---|---|---|
ML-KEM-512 keypair |
34845 cycles |
34847 cycles |
1.00 |
ML-KEM-512 encaps |
45002 cycles |
45080 cycles |
1.00 |
ML-KEM-512 decaps |
58909 cycles |
58969 cycles |
1.00 |
ML-KEM-768 keypair |
59152 cycles |
59111 cycles |
1.00 |
ML-KEM-768 encaps |
71767 cycles |
71787 cycles |
1.00 |
ML-KEM-768 decaps |
89239 cycles |
89310 cycles |
1.00 |
ML-KEM-1024 keypair |
87635 cycles |
87395 cycles |
1.00 |
ML-KEM-1024 encaps |
104563 cycles |
104584 cycles |
1.00 |
ML-KEM-1024 decaps |
127618 cycles |
127599 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Graviton4
Benchmark suite | Current: 3b3ee3d | Previous: 84bdac8 | Ratio |
---|---|---|---|
ML-KEM-512 keypair |
18135 cycles |
18139 cycles |
1.00 |
ML-KEM-512 encaps |
22146 cycles |
22154 cycles |
1.00 |
ML-KEM-512 decaps |
28774 cycles |
28791 cycles |
1.00 |
ML-KEM-768 keypair |
30573 cycles |
30570 cycles |
1.00 |
ML-KEM-768 encaps |
33647 cycles |
33633 cycles |
1.00 |
ML-KEM-768 decaps |
43165 cycles |
43175 cycles |
1.00 |
ML-KEM-1024 keypair |
44214 cycles |
44210 cycles |
1.00 |
ML-KEM-1024 encaps |
49656 cycles |
49661 cycles |
1.00 |
ML-KEM-1024 decaps |
62637 cycles |
62653 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arm Cortex-A55 (Snapdragon 888) benchmarks
Benchmark suite | Current: 3b3ee3d | Previous: 84bdac8 | Ratio |
---|---|---|---|
ML-KEM-512 keypair |
58375 cycles |
58392 cycles |
1.00 |
ML-KEM-512 encaps |
65781 cycles |
65793 cycles |
1.00 |
ML-KEM-512 decaps |
84562 cycles |
84549 cycles |
1.00 |
ML-KEM-768 keypair |
98993 cycles |
99156 cycles |
1.00 |
ML-KEM-768 encaps |
110710 cycles |
110374 cycles |
1.00 |
ML-KEM-768 decaps |
136722 cycles |
137616 cycles |
0.99 |
ML-KEM-1024 keypair |
150189 cycles |
150209 cycles |
1.00 |
ML-KEM-1024 encaps |
166842 cycles |
166648 cycles |
1.00 |
ML-KEM-1024 decaps |
202588 cycles |
202380 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AMD EPYC 3rd gen (c6a) (no-opt)
Benchmark suite | Current: 3b3ee3d | Previous: 84bdac8 | Ratio |
---|---|---|---|
ML-KEM-512 keypair |
52385 cycles |
52203 cycles |
1.00 |
ML-KEM-512 encaps |
65392 cycles |
65806 cycles |
0.99 |
ML-KEM-512 decaps |
88511 cycles |
88407 cycles |
1.00 |
ML-KEM-768 keypair |
84295 cycles |
84781 cycles |
0.99 |
ML-KEM-768 encaps |
102015 cycles |
101469 cycles |
1.01 |
ML-KEM-768 decaps |
131251 cycles |
132123 cycles |
0.99 |
ML-KEM-1024 keypair |
124697 cycles |
124011 cycles |
1.01 |
ML-KEM-1024 encaps |
145214 cycles |
145953 cycles |
0.99 |
ML-KEM-1024 decaps |
182750 cycles |
183659 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AMD EPYC 4th gen (c7a) (no-opt)
Benchmark suite | Current: 3b3ee3d | Previous: 84bdac8 | Ratio |
---|---|---|---|
ML-KEM-512 keypair |
45757 cycles |
45724 cycles |
1.00 |
ML-KEM-512 encaps |
56884 cycles |
56857 cycles |
1.00 |
ML-KEM-512 decaps |
76192 cycles |
76236 cycles |
1.00 |
ML-KEM-768 keypair |
74464 cycles |
74512 cycles |
1.00 |
ML-KEM-768 encaps |
88504 cycles |
88566 cycles |
1.00 |
ML-KEM-768 decaps |
114370 cycles |
114371 cycles |
1.00 |
ML-KEM-1024 keypair |
109367 cycles |
109426 cycles |
1.00 |
ML-KEM-1024 encaps |
127459 cycles |
127309 cycles |
1.00 |
ML-KEM-1024 decaps |
159993 cycles |
160035 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intel Xeon 3rd gen (c6i) (no-opt)
Benchmark suite | Current: 3b3ee3d | Previous: 84bdac8 | Ratio |
---|---|---|---|
ML-KEM-512 keypair |
56606 cycles |
56574 cycles |
1.00 |
ML-KEM-512 encaps |
69454 cycles |
69459 cycles |
1.00 |
ML-KEM-512 decaps |
91398 cycles |
91364 cycles |
1.00 |
ML-KEM-768 keypair |
91890 cycles |
91851 cycles |
1.00 |
ML-KEM-768 encaps |
107778 cycles |
107798 cycles |
1.00 |
ML-KEM-768 decaps |
136557 cycles |
136335 cycles |
1.00 |
ML-KEM-1024 keypair |
134710 cycles |
134728 cycles |
1.00 |
ML-KEM-1024 encaps |
155378 cycles |
155213 cycles |
1.00 |
ML-KEM-1024 decaps |
191585 cycles |
191515 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Graviton2
Benchmark suite | Current: 3b3ee3d | Previous: 84bdac8 | Ratio |
---|---|---|---|
ML-KEM-512 keypair |
29054 cycles |
29019 cycles |
1.00 |
ML-KEM-512 encaps |
35369 cycles |
35402 cycles |
1.00 |
ML-KEM-512 decaps |
45899 cycles |
45888 cycles |
1.00 |
ML-KEM-768 keypair |
49395 cycles |
49359 cycles |
1.00 |
ML-KEM-768 encaps |
55613 cycles |
55582 cycles |
1.00 |
ML-KEM-768 decaps |
70373 cycles |
70299 cycles |
1.00 |
ML-KEM-1024 keypair |
72079 cycles |
72010 cycles |
1.00 |
ML-KEM-1024 encaps |
80868 cycles |
80785 cycles |
1.00 |
ML-KEM-1024 decaps |
100732 cycles |
100659 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Graviton4 (no-opt)
Benchmark suite | Current: 3b3ee3d | Previous: 84bdac8 | Ratio |
---|---|---|---|
ML-KEM-512 keypair |
42017 cycles |
41959 cycles |
1.00 |
ML-KEM-512 encaps |
50090 cycles |
50162 cycles |
1.00 |
ML-KEM-512 decaps |
66106 cycles |
66048 cycles |
1.00 |
ML-KEM-768 keypair |
69114 cycles |
69052 cycles |
1.00 |
ML-KEM-768 encaps |
79857 cycles |
79761 cycles |
1.00 |
ML-KEM-768 decaps |
101127 cycles |
101017 cycles |
1.00 |
ML-KEM-1024 keypair |
102216 cycles |
102205 cycles |
1.00 |
ML-KEM-1024 encaps |
117215 cycles |
117207 cycles |
1.00 |
ML-KEM-1024 decaps |
143448 cycles |
143696 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Graviton3
Benchmark suite | Current: 3b3ee3d | Previous: 84bdac8 | Ratio |
---|---|---|---|
ML-KEM-512 keypair |
18972 cycles |
18967 cycles |
1.00 |
ML-KEM-512 encaps |
23554 cycles |
23554 cycles |
1 |
ML-KEM-512 decaps |
30653 cycles |
30665 cycles |
1.00 |
ML-KEM-768 keypair |
32310 cycles |
32293 cycles |
1.00 |
ML-KEM-768 encaps |
35891 cycles |
35890 cycles |
1.00 |
ML-KEM-768 decaps |
46001 cycles |
46033 cycles |
1.00 |
ML-KEM-1024 keypair |
46621 cycles |
46626 cycles |
1.00 |
ML-KEM-1024 encaps |
52458 cycles |
52445 cycles |
1.00 |
ML-KEM-1024 decaps |
66290 cycles |
66245 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Graviton2 (no-opt)
Benchmark suite | Current: 3b3ee3d | Previous: 84bdac8 | Ratio |
---|---|---|---|
ML-KEM-512 keypair |
71313 cycles |
71257 cycles |
1.00 |
ML-KEM-512 encaps |
85160 cycles |
85073 cycles |
1.00 |
ML-KEM-512 decaps |
112678 cycles |
112756 cycles |
1.00 |
ML-KEM-768 keypair |
117819 cycles |
117424 cycles |
1.00 |
ML-KEM-768 encaps |
135431 cycles |
135180 cycles |
1.00 |
ML-KEM-768 decaps |
172178 cycles |
171795 cycles |
1.00 |
ML-KEM-1024 keypair |
175461 cycles |
174627 cycles |
1.00 |
ML-KEM-1024 encaps |
197604 cycles |
196786 cycles |
1.00 |
ML-KEM-1024 decaps |
243863 cycles |
242801 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Graviton3 (no-opt)
Benchmark suite | Current: 3b3ee3d | Previous: 84bdac8 | Ratio |
---|---|---|---|
ML-KEM-512 keypair |
45396 cycles |
45391 cycles |
1.00 |
ML-KEM-512 encaps |
54209 cycles |
54219 cycles |
1.00 |
ML-KEM-512 decaps |
71143 cycles |
71155 cycles |
1.00 |
ML-KEM-768 keypair |
74829 cycles |
74822 cycles |
1.00 |
ML-KEM-768 encaps |
86076 cycles |
86055 cycles |
1.00 |
ML-KEM-768 decaps |
108670 cycles |
108797 cycles |
1.00 |
ML-KEM-1024 keypair |
111109 cycles |
111123 cycles |
1.00 |
ML-KEM-1024 encaps |
125925 cycles |
125928 cycles |
1.00 |
ML-KEM-1024 decaps |
154584 cycles |
154616 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bananapi bpi-f3 benchmarks
Benchmark suite | Current: 3b3ee3d | Previous: 84bdac8 | Ratio |
---|---|---|---|
ML-KEM-512 keypair |
335094 cycles |
335097 cycles |
1.00 |
ML-KEM-512 encaps |
445788 cycles |
445748 cycles |
1.00 |
ML-KEM-512 decaps |
593827 cycles |
593813 cycles |
1.00 |
ML-KEM-768 keypair |
556165 cycles |
556254 cycles |
1.00 |
ML-KEM-768 encaps |
698030 cycles |
698083 cycles |
1.00 |
ML-KEM-768 decaps |
889804 cycles |
889797 cycles |
1.00 |
ML-KEM-1024 keypair |
821806 cycles |
821794 cycles |
1.00 |
ML-KEM-1024 encaps |
999531 cycles |
999321 cycles |
1.00 |
ML-KEM-1024 decaps |
1230374 cycles |
1230188 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arm Cortex-A72 (Raspberry Pi 4) benchmarks
Benchmark suite | Current: 3b3ee3d | Previous: 84bdac8 | Ratio |
---|---|---|---|
ML-KEM-512 keypair |
51868 cycles |
51941 cycles |
1.00 |
ML-KEM-512 encaps |
58370 cycles |
59357 cycles |
0.98 |
ML-KEM-512 decaps |
74778 cycles |
75134 cycles |
1.00 |
ML-KEM-768 keypair |
88395 cycles |
87839 cycles |
1.01 |
ML-KEM-768 encaps |
96095 cycles |
96730 cycles |
0.99 |
ML-KEM-768 decaps |
119160 cycles |
118986 cycles |
1.00 |
ML-KEM-1024 keypair |
131421 cycles |
131265 cycles |
1.00 |
ML-KEM-1024 encaps |
143901 cycles |
144874 cycles |
0.99 |
ML-KEM-1024 decaps |
175582 cycles |
175688 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @mkannwischer - Great we have no non standard dependencies anymore!
Left two non blocking questions.
Signed-off-by: Matthias J. Kannwischer <[email protected]>
Signed-off-by: Matthias J. Kannwischer <[email protected]>
Signed-off-by: Matthias J. Kannwischer <[email protected]>
3b3ee3d
to
19990c5
Compare
As python dependencies are removed in pq-code-package#573, only python3 is needed in the dependencies Signed-off-by: Thing-han, Lim <[email protected]>
As python dependencies are removed in pq-code-package#573, only python3 is needed in the dependencies Signed-off-by: Thing-han, Lim <[email protected]>
As python dependencies are removed in #573, only python3 is needed in the dependencies Signed-off-by: Thing-han, Lim <[email protected]>
As python dependencies are removed in #573, only python3 is needed in the dependencies Signed-off-by: Thing-han, Lim <[email protected]>
As python dependencies are removed in #573, only python3 is needed in the dependencies Signed-off-by: Thing-han, Lim <[email protected]>
As python dependencies are removed in #573, only python3 is needed in the dependencies Signed-off-by: Thing-han, Lim <[email protected]>
As python dependencies are removed in #573, only python3 is needed in the dependencies Signed-off-by: Thing-han, Lim <[email protected]>
As python dependencies are removed in #573, only python3 is needed in the dependencies Signed-off-by: Thing-han, Lim <[email protected]>
This PR eliminates the last pip dependency
click
and adjusts CI and documentation accordingly.click
#565