-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move and clean up Silence
#12441
base: master
Are you sure you want to change the base?
Move and clean up Silence
#12441
Conversation
Need to get a new screenshot for the German version, and ask for a review of the wording and factual accuracy.
"Timed out" is not a term in osu!.
…into silence-rework
Long silence lengths are now universally 43 hours, not 42 or (on older translations) 48 - except for the Russian version. Some versions had the phrase "timed out" removed since it's not a phrase in osu!. Not all, however. The Danish translation was partially fixed as well (it used to say users *themselves* could be removed after 3 months of a restriction instead of the restriction being removed).
Someone else has edited same files as you did. Please check their changes in case they conflict with yours: |
i notified the GMT of the osu!wiki thread, we should take this opportunity to discuss some wiki enhancements and add it either via this PR or a separate one |
Added PR number to ``redirect.yaml`` as well
…into silence-rework
Added a section about what happens for inappropriate visual content and related penalties to the VCC page, like the Song Content Rules page has.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the 42->43 stuff is ok but pls dont make wording changes in translations in a PR like this, it makes review difficult
e: can keep DE changes since someone already reviewed.
Co-authored-by: clayton <[email protected]>
French translation of `Rules` reverted. Since I am a native Danish speaker, those changes should be fine.
@cl8n reverted French translation change, Danish should (?) be fine since I'm a native speaker |
Co-authored-by: Walavouchey <[email protected]>
…into silence-rework
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"43 hours" is weird but sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the GMT have concluded that we as a team need to further discuss what additions we want to make, therefore for now silence lengths or specific reasons should not be a part of this PR
the GMT & wiki maintainers will be handling any future updates to this page if we conclude that changes need to be made
I wish we would be doing less of this going forward, and not more. community wikis are more useful when they freely document anything that could be relevant to readers |
Yeah I don't get what the above messaging even means. But also I'm a bit against having "specific durations for specific offences" since that's not how the system historically worked. |
i didnt express myself properly when i said "the gmt/wiki maintainers will handle updates going forward", my point was that these changes cannot just be added without consulting the team first, hence why I notified everyone of the proposed changes. also meant to say that I will open a PR when the team decides what to update, so this doesn't stay open for an extended period of time after a discussion and a vote we didn't get crystal clear results of what the team wants (after all, its 60+ people with different opinions), but the majority agreed that what was added by userlog2 should not be there until we cleared up internally what we want the team wants some stuff to be updated, we are just not sure what yet, and need some extra time to iron the details out |
Co-authored-by: 0x84f <[email protected]>
Silence
regarding lengthsSilence
matches related articles (Account_restrictions, Tournament_bans)
Someone else has edited same files as you did. Please check their changes in case they conflict with yours: |
Someone else has edited same files as you did. Please check their changes in case they conflict with yours: |
Should be ready for merge now, waiting on final review
Changed Silence article to add details regarding silence lengthsthis will come in a different PR, after an internal discussion within the GMT.Note: I speak relatively fluent Danish; I will therefore be correcting mistakes if I see any. A full update of that page will come later in a different PR.
To do
Self-check