-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing tf.function parameters #142
Open
tatianacv
wants to merge
24
commits into
ponder-lab:main
Choose a base branch
from
tatianacv:139-missing-tffunction-parameters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
5bfb831
adding two missing params
tatianacv 0f84bb0
fix trailing whitespace
tatianacv 8872d38
Merge remote-tracking branch 'upstream/main' into 139-missing-tffunct…
tatianacv fe4a4f0
Progress
tatianacv b13b3d2
Fix
tatianacv 700d3bf
Merge branch 'main' into 139-missing-tffunction-parameters
tatianacv 3ca358f
Maintaining the same format
tatianacv e659e93
Formatting, trailing whitespace
tatianacv 3f284f1
Maintaining the same format
tatianacv f587254
Passing build
tatianacv 35fd7a7
Merge branch 'main' into 139-missing-tffunction-parameters
khatchad 52e25b8
Merge branch 'main' into 139-missing-tffunction-parameters
khatchad fee0cbc
Adding more information
tatianacv 8f79e34
Adding more information
tatianacv 2215e1f
Restructure sentence
tatianacv f4047bf
Restructure sentence
tatianacv cbfd513
Adding additional information to field description (link included)
tatianacv 20b4418
Merge branch 'main' into 139-missing-tffunction-parameters
tatianacv ce615bb
Merge branch 'main' into 139-missing-tffunction-parameters
khatchad 3ffd5a9
Adding specific URLs
tatianacv 617cfb5
removing HTML
tatianacv c9a3be5
Merge branch 'main' into 139-missing-tffunction-parameters
khatchad 98a669e
Merge branch 'main' into 139-missing-tffunction-parameters
tatianacv 0d64c55
matching anchor with field name
tatianacv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -93,14 +93,14 @@ public class HybridizationParameters { | |
|
||
/** | ||
* True iff this {@link Function}'s {@link decoratorsType} has parameter jit_compile and deprecated name experimental_compile. For | ||
* more information, you can see this <a href="https://www.tensorflow.org/versions/r2.9/api_docs/python/tf/function">URL</a>. | ||
* more information, you can see this https://tensorflow.org/versions/r2.9/api_docs/python/tf/function#experimental_compile. | ||
*/ | ||
private boolean jitCompileParamExists; | ||
|
||
/** | ||
* True iff this {@link Function}'s {@link decoratorsType} has parameter reduce_retracing and deprecated name | ||
* experimental_relax_shapes. For more information, you can see this | ||
* <a href="https://www.tensorflow.org/versions/r2.9/api_docs/python/tf/function">URL</a>. | ||
* https://tensorflow.org/versions/r2.9/api_docs/python/tf/function#experimental_relax_shapes | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The anchor doesn't match the field name. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated. |
||
*/ | ||
private boolean reduceRetracingParamExists; | ||
|
||
|
@@ -245,24 +245,26 @@ public boolean hasReduceRetracingParam() { | |
} | ||
|
||
/** | ||
* True iff this {@link Function}'s {@link decoratorsType} has parameter experimental_compile. | ||
* True iff this {@link Function}'s {@link decoratorsType} has parameter experimental_compile. Since jit_compile and | ||
tatianacv marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* experimental_compile (deprecated) have the same functionalities, when we parse these parameters together it is stored into the | ||
* same boolean variable. For more information, you can see this link | ||
* https://tensorflow.org/versions/r2.9/api_docs/python/tf/function#experimental_compile | ||
* | ||
* @return True iff this {@link Function} has parameter experimental_compile. | ||
*/ | ||
public boolean hasExperimentalCompileParam() { | ||
// Since jit_compile and experimental_compile (deprecated) have the same functionalities, when we parse these parameters | ||
// together and store it into the same boolean variable. | ||
return this.jitCompileParamExists; | ||
khatchad marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
/** | ||
* True iff this {@link Function}'s {@link decoratorsType} has parameter experimental_relax_shapes. | ||
* True iff this {@link Function}'s {@link decoratorsType} has parameter experimental_relax_shapes. Since reduce_retracing and | ||
* experimental_relax_shapes (deprecated) have the same functionalities, when we parse these parameters together it is stored into | ||
* the same boolean variable. For more information, you can see this link | ||
* https://tensorflow.org/versions/r2.9/api_docs/python/tf/function#experimental_relax_shapes | ||
* | ||
* @return True iff this {@link Function} has parameter experimental_relax_shapes. | ||
*/ | ||
public boolean hasExperimentalRelaxShapesParam() { | ||
// Since reduce_retracing and experimental_relax_shapes (deprecated) have the same functionalities, when we parse these | ||
// parameters together and store it into the same boolean variable. | ||
return this.reduceRetracingParamExists; | ||
} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The anchor doesn't match the field name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.