Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tf.function parameters #142

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open
Changes from 4 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
5bfb831
adding two missing params
tatianacv Jan 24, 2023
0f84bb0
fix trailing whitespace
tatianacv Jan 24, 2023
8872d38
Merge remote-tracking branch 'upstream/main' into 139-missing-tffunct…
tatianacv Jan 26, 2023
fe4a4f0
Progress
tatianacv Jan 26, 2023
b13b3d2
Fix
tatianacv Jan 26, 2023
700d3bf
Merge branch 'main' into 139-missing-tffunction-parameters
tatianacv Jan 31, 2023
3ca358f
Maintaining the same format
tatianacv Feb 26, 2023
e659e93
Formatting, trailing whitespace
tatianacv Feb 26, 2023
3f284f1
Maintaining the same format
tatianacv Feb 26, 2023
f587254
Passing build
tatianacv Feb 27, 2023
35fd7a7
Merge branch 'main' into 139-missing-tffunction-parameters
khatchad Mar 4, 2023
52e25b8
Merge branch 'main' into 139-missing-tffunction-parameters
khatchad Mar 5, 2023
fee0cbc
Adding more information
tatianacv Mar 6, 2023
8f79e34
Adding more information
tatianacv Mar 6, 2023
2215e1f
Restructure sentence
tatianacv Mar 8, 2023
f4047bf
Restructure sentence
tatianacv Mar 8, 2023
cbfd513
Adding additional information to field description (link included)
tatianacv Mar 15, 2023
20b4418
Merge branch 'main' into 139-missing-tffunction-parameters
tatianacv Mar 15, 2023
ce615bb
Merge branch 'main' into 139-missing-tffunction-parameters
khatchad Mar 21, 2023
3ffd5a9
Adding specific URLs
tatianacv Mar 22, 2023
617cfb5
removing HTML
tatianacv Mar 22, 2023
c9a3be5
Merge branch 'main' into 139-missing-tffunction-parameters
khatchad Mar 28, 2023
98a669e
Merge branch 'main' into 139-missing-tffunction-parameters
tatianacv Mar 31, 2023
0d64c55
matching anchor with field name
tatianacv Mar 31, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -93,14 +93,14 @@ public class HybridizationParameters {

/**
* True iff this {@link Function}'s {@link decoratorsType} has parameter jit_compile and deprecated name experimental_compile. For
* more information, you can see this <a href="https://www.tensorflow.org/versions/r2.9/api_docs/python/tf/function">URL</a>.
* more information, you can see this https://tensorflow.org/versions/r2.9/api_docs/python/tf/function#experimental_compile.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The anchor doesn't match the field name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

*/
private boolean jitCompileParamExists;

/**
* True iff this {@link Function}'s {@link decoratorsType} has parameter reduce_retracing and deprecated name
* experimental_relax_shapes. For more information, you can see this
* <a href="https://www.tensorflow.org/versions/r2.9/api_docs/python/tf/function">URL</a>.
* https://tensorflow.org/versions/r2.9/api_docs/python/tf/function#experimental_relax_shapes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The anchor doesn't match the field name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

*/
private boolean reduceRetracingParamExists;

Expand Down Expand Up @@ -245,24 +245,26 @@ public boolean hasReduceRetracingParam() {
}

/**
* True iff this {@link Function}'s {@link decoratorsType} has parameter experimental_compile.
* True iff this {@link Function}'s {@link decoratorsType} has parameter experimental_compile. Since jit_compile and
tatianacv marked this conversation as resolved.
Show resolved Hide resolved
* experimental_compile (deprecated) have the same functionalities, when we parse these parameters together it is stored into the
* same boolean variable. For more information, you can see this link
* https://tensorflow.org/versions/r2.9/api_docs/python/tf/function#experimental_compile
*
* @return True iff this {@link Function} has parameter experimental_compile.
*/
public boolean hasExperimentalCompileParam() {
// Since jit_compile and experimental_compile (deprecated) have the same functionalities, when we parse these parameters
// together and store it into the same boolean variable.
return this.jitCompileParamExists;
khatchad marked this conversation as resolved.
Show resolved Hide resolved
}

/**
* True iff this {@link Function}'s {@link decoratorsType} has parameter experimental_relax_shapes.
* True iff this {@link Function}'s {@link decoratorsType} has parameter experimental_relax_shapes. Since reduce_retracing and
* experimental_relax_shapes (deprecated) have the same functionalities, when we parse these parameters together it is stored into
* the same boolean variable. For more information, you can see this link
* https://tensorflow.org/versions/r2.9/api_docs/python/tf/function#experimental_relax_shapes
*
* @return True iff this {@link Function} has parameter experimental_relax_shapes.
*/
public boolean hasExperimentalRelaxShapesParam() {
// Since reduce_retracing and experimental_relax_shapes (deprecated) have the same functionalities, when we parse these
// parameters together and store it into the same boolean variable.
return this.reduceRetracingParamExists;
}

Expand Down