Add missing tf.function parameters #142

tatianacv · 2023-01-24T04:58:12Z

Fixes #139.

Commits

I slowed down and took a deep breadth before committing. Otherwise, I will start a pristine branch and reissue this pull request.
Before committing my changes, I checked my working directory carefully. I only staged the changes I wanted and ensured it was of the utmost quality.
I used git diff and git status to check my work carefully before committing.
I completely understand what I am committing and why.
I completely understand why things are the way they are.
The change I am proposing makes complete sense to me.
For the most part, the changes in this pull request correspond to the problem or task I am solving or performing. In other words, only the changes that are supposed to be there are the ones included in this pull request.

Expectations

We should now have the params experimental_compile and experimental_relax_shapes. We added getters to those tf.function parameters and added an additional check for these in the tests.

Testing

If this is a bug fix, I was able to reproduce the problem locally before I made any changes (can use git stash to temporarily reset the working directory).
When I made (or put back) my changes, the problem I reproduced above was fixed.

Added another conditional statement to reflect the missing tf.function parameters.

Final Checks

The changes I am proposing meet the expectations I have described above.
I have performed a self-review of my code.
I have commented my code, particularly in hard-to-understand areas.
I have made corresponding changes to the documentation if applicable.
I have added tests that prove my fix is effective or that my feature works if applicable.
New and existing unit tests pass locally with my changes.

edu.cuny.hunter.hybridize.core/src/edu/cuny/hunter/hybridize/core/analysis/Function.java

khatchad · 2023-01-26T15:08:52Z

What is the status of this one? Are there changes for me to review since the last time I saw it? Also, it looks like there's a conflict now.

khatchad · 2023-01-26T15:09:18Z

I had a look at the conflict. I don't think I can resolve it.

…ion-parameters

tatianacv · 2023-01-26T19:17:17Z

What is the status of this one? Are there changes for me to review since the last time I saw it? Also, it looks like there's a conflict now.

I resolved the conflict. We have a pending discussion.

edu.cuny.hunter.hybridize.core/src/edu/cuny/hunter/hybridize/core/analysis/Function.java

khatchad

Not sure how these convos got resolved.

khatchad · 2023-03-21T00:31:08Z

edu.cuny.hunter.hybridize.core/src/edu/cuny/hunter/hybridize/core/analysis/Function.java

-		 * True iff this {@link Function}'s {@link decoratorsType} has parameter reduce_retracing.
+		 * True iff this {@link Function}'s {@link decoratorsType} has parameter reduce_retracing and deprecated name
+		 * experimental_relax_shapes. For more information, you can see this
+		 * <a href="https://www.tensorflow.org/versions/r2.9/api_docs/python/tf/function">URL</a>.


Just the URL is fine; we don't need HTML. I still don't see the HTML anchor reference to the specific field.

I have added it.

edu.cuny.hunter.hybridize.core/src/edu/cuny/hunter/hybridize/core/analysis/Function.java

khatchad · 2023-03-28T18:50:52Z

edu.cuny.hunter.hybridize.core/src/edu/cuny/hunter/hybridize/core/analysis/Function.java

@@ -93,14 +93,14 @@ public class HybridizationParameters {

 		/**
 		 * True iff this {@link Function}'s {@link decoratorsType} has parameter jit_compile and deprecated name experimental_compile. For
-		 * more information, you can see this <a href="https://www.tensorflow.org/versions/r2.9/api_docs/python/tf/function">URL</a>.
+		 * more information, you can see this https://tensorflow.org/versions/r2.9/api_docs/python/tf/function#experimental_compile.


The anchor doesn't match the field name.

khatchad · 2023-03-28T18:50:57Z

edu.cuny.hunter.hybridize.core/src/edu/cuny/hunter/hybridize/core/analysis/Function.java

 		 */
 		private boolean jitCompileParamExists;

 		/**
 		 * True iff this {@link Function}'s {@link decoratorsType} has parameter reduce_retracing and deprecated name
 		 * experimental_relax_shapes. For more information, you can see this
-		 * <a href="https://www.tensorflow.org/versions/r2.9/api_docs/python/tf/function">URL</a>.
+		 * https://tensorflow.org/versions/r2.9/api_docs/python/tf/function#experimental_relax_shapes


The anchor doesn't match the field name.

edu.cuny.hunter.hybridize.core/src/edu/cuny/hunter/hybridize/core/analysis/Function.java

tatianacv added 2 commits January 23, 2023 23:34

adding two missing params

5bfb831

fix trailing whitespace

0f84bb0

tatianacv requested a review from khatchad as a code owner January 24, 2023 04:58

khatchad requested changes Jan 24, 2023

View reviewed changes

edu.cuny.hunter.hybridize.core/src/edu/cuny/hunter/hybridize/core/analysis/Function.java Outdated Show resolved Hide resolved

khatchad changed the title ~~Adding missing tffunction parameters~~ Add missing tf.function parameters Jan 24, 2023

tatianacv mentioned this pull request Jan 24, 2023

Process positional arguments #134

Open

15 tasks

Merge remote-tracking branch 'upstream/main' into 139-missing-tffunct…

8872d38

…ion-parameters

tatianacv added 7 commits January 26, 2023 15:40

Progress

fe4a4f0

Fix

b13b3d2

Merge branch 'main' into 139-missing-tffunction-parameters

700d3bf

Maintaining the same format

3ca358f

Formatting, trailing whitespace

e659e93

Maintaining the same format

3f284f1

Passing build

f587254

tatianacv requested a review from khatchad February 28, 2023 17:16

Merge branch 'main' into 139-missing-tffunction-parameters

35fd7a7

khatchad requested changes Mar 4, 2023

View reviewed changes

edu.cuny.hunter.hybridize.core/src/edu/cuny/hunter/hybridize/core/analysis/Function.java Show resolved Hide resolved

khatchad and others added 5 commits March 4, 2023 19:04

Merge branch 'main' into 139-missing-tffunction-parameters

52e25b8

Adding more information

fee0cbc

Adding more information

8f79e34

Restructure sentence

2215e1f

Restructure sentence

f4047bf

khatchad requested changes Mar 9, 2023

View reviewed changes

edu.cuny.hunter.hybridize.core/src/edu/cuny/hunter/hybridize/core/analysis/Function.java Show resolved Hide resolved

khatchad requested changes Mar 15, 2023

View reviewed changes

tatianacv added 2 commits March 15, 2023 17:21

Adding additional information to field description (link included)

cbfd513

Merge branch 'main' into 139-missing-tffunction-parameters

20b4418

khatchad requested changes Mar 21, 2023

View reviewed changes

khatchad and others added 4 commits March 20, 2023 20:37

Merge branch 'main' into 139-missing-tffunction-parameters

ce615bb

Adding specific URLs

3ffd5a9

removing HTML

617cfb5

Merge branch 'main' into 139-missing-tffunction-parameters

c9a3be5

khatchad previously approved these changes Mar 28, 2023

View reviewed changes

tatianacv added 2 commits March 31, 2023 17:08

Merge branch 'main' into 139-missing-tffunction-parameters

98a669e

matching anchor with field name

0d64c55

tatianacv dismissed khatchad’s stale review via 0d64c55 March 31, 2023 21:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing tf.function parameters #142

Add missing tf.function parameters #142

tatianacv commented Jan 24, 2023 •

edited

Loading

khatchad commented Jan 26, 2023

khatchad commented Jan 26, 2023

tatianacv commented Jan 26, 2023

khatchad left a comment

khatchad Mar 21, 2023

tatianacv Mar 23, 2023

khatchad Mar 28, 2023

tatianacv Mar 31, 2023

khatchad Mar 28, 2023

tatianacv Mar 31, 2023

Add missing tf.function parameters #142

Are you sure you want to change the base?

Add missing tf.function parameters #142

Conversation

tatianacv commented Jan 24, 2023 • edited Loading

Commits

Expectations

Testing

Final Checks

khatchad commented Jan 26, 2023

khatchad commented Jan 26, 2023

tatianacv commented Jan 26, 2023

khatchad left a comment

Choose a reason for hiding this comment

khatchad Mar 21, 2023

Choose a reason for hiding this comment

tatianacv Mar 23, 2023

Choose a reason for hiding this comment

khatchad Mar 28, 2023

Choose a reason for hiding this comment

tatianacv Mar 31, 2023

Choose a reason for hiding this comment

khatchad Mar 28, 2023

Choose a reason for hiding this comment

tatianacv Mar 31, 2023

Choose a reason for hiding this comment

tatianacv commented Jan 24, 2023 •

edited

Loading