Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compat with aiohttp 3.11.0+ #262

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Fix compat with aiohttp 3.11.0+ #262

merged 1 commit into from
Nov 15, 2024

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Nov 13, 2024 •
edited
Loading

This is still backwards compatible with older versions (tested with 3.10.11 and 3.9.5) as well.

This was referenced Nov 13, 2024
Merged
Closed
Closed
@vincbeck vincbeck mentioned this pull request Nov 13, 2024
Closed
cdessez
cdessez approved these changes Nov 13, 2024
View reviewed changes
Copy link

@cdessez cdessez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible to me, although I admittedly don't know the internals of the library. Approving in spirit but I'm not sure this should be enough to merge it.

@bartfeenstra bartfeenstra mentioned this pull request Nov 13, 2024
Closed
potiuk added a commit to potiuk/airflow that referenced this pull request Nov 13, 2024
@potiuk
Limit temporarily aiohttp to < 3.11.0
fcd2431 
Because of aio-libs/aiohttp#9866 some tests are failing. This PR can be
reverted when pnuckowski/aioresponses#262 is merged and released
@potiuk potiuk mentioned this pull request Nov 13, 2024
Closed
potiuk added a commit to potiuk/airflow that referenced this pull request Nov 14, 2024
@potiuk
Limit temporarily aiohttp to < 3.11.0
d3d0d32 
Because of aio-libs/aiohttp#9866 some tests are failing. This PR can be
reverted when pnuckowski/aioresponses#262 is merged and released
@potiuk potiuk mentioned this pull request Nov 14, 2024
Merged
potiuk added a commit to potiuk/airflow that referenced this pull request Nov 14, 2024
@potiuk
Limit temporarily aiohttp to < 3.11.0
bc9698b 
Because of aio-libs/aiohttp#9866 some tests are failing. This PR can be
reverted when pnuckowski/aioresponses#262 is merged and released
@potiuk
Copy link

potiuk commented Nov 14, 2024

Yep. Would be great to have a fix for it released. If there is a way we can speed it up?

potiuk added a commit to apache/airflow that referenced this pull request Nov 14, 2024
@potiuk
Limit temporarily aiohttp to < 3.11.0 (#44006)
e7a0ddd 
Because of aio-libs/aiohttp#9866 some tests are failing. This PR can be
reverted when pnuckowski/aioresponses#262 is merged and released
amoghrajesh pushed a commit to astronomer/airflow that referenced this pull request Nov 14, 2024
@potiuk @amoghrajesh
Limit temporarily aiohttp to < 3.11.0 (apache#44006)
ac8d4d3 
Because of aio-libs/aiohttp#9866 some tests are failing. This PR can be
reverted when pnuckowski/aioresponses#262 is merged and released
@kingsleyadam kingsleyadam mentioned this pull request Nov 14, 2024
Merged
@Alex-Izquierdo Alex-Izquierdo mentioned this pull request Nov 14, 2024
Merged
@dknowles2 dknowles2 mentioned this pull request Nov 14, 2024
Closed
@bdraco bdraco mentioned this pull request Nov 14, 2024
Merged
@bdraco
Copy link
Contributor Author

bdraco commented Nov 14, 2024

We are going to release a 3.11.1 for backwards compat. https://github.com/aio-libs/aiohttp/actions/runs/11840386977

It would still be good to merge this change though since we don't expect RequestInfo objects to be created outside of aiohttp internals and it may break again in the future.

@bdraco
Copy link
Contributor Author

bdraco commented Nov 14, 2024

3.11.1 is available on PyPI

bdraco added a commit to home-assistant/core that referenced this pull request Nov 14, 2024
@bdraco
Bump aiohttp to 3.11.1
9e6ce29 
changelog: aio-libs/aiohttp@v3.11.0...v3.11.1

no functional changes, release was only to restore compat for
testing in pnuckowski/aioresponses#262
@bdraco bdraco mentioned this pull request Nov 14, 2024
Merged
19 tasks
kaxil added a commit to astronomer/airflow that referenced this pull request Nov 14, 2024
@kaxil
Bump aiohttp to 3.11.1
6a328df 
aio-libs/aiohttp#9866 was fixed by pnuckowski/aioresponses#262 (comment)

https://pypi.org/project/aiohttp/3.11.1/
@kaxil kaxil mentioned this pull request Nov 14, 2024
Merged
@potiuk
Copy link

potiuk commented Nov 14, 2024

3.11.1 is available on PyPI

Nice. Thanks!

@pnuckowski - is the aioresponses library maintained?

kaxil added a commit to astronomer/airflow that referenced this pull request Nov 14, 2024
@kaxil
Apply suggestions from code review
8aec6af 
Bump `aiohttp` to `3.11.1`

aio-libs/aiohttp#9866 was fixed by pnuckowski/aioresponses#262 (comment)

https://pypi.org/project/aiohttp/3.11.1/
kaxil added a commit to apache/airflow that referenced this pull request Nov 14, 2024
@kaxil
Apply suggestions from code review (#44036)
cc7b7a2 
Bump `aiohttp` to `3.11.1`

aio-libs/aiohttp#9866 was fixed by pnuckowski/aioresponses#262 (comment)

https://pypi.org/project/aiohttp/3.11.1/
@pnuckowski pnuckowski merged commit 827d4c2 into pnuckowski:master Nov 15, 2024
20 checks passed
@cdessez
Copy link

cdessez commented Nov 15, 2024

Thanks, guys! 👍
Can you also trigger a release to have this fix available in the latest PyPI package?

@bdraco bdraco deleted the 3110_compat branch November 15, 2024 12:07
@pnuckowski
Copy link
Owner

Thanks, guys! 👍 Can you also trigger a release to have this fix available in the latest PyPI package?

today will upload, first need to fix some issues that occur while uploading to pypi :/ stay tuned

Alex-Izquierdo added a commit to ansible/ansible-rulebook that referenced this pull request Nov 15, 2024
@Alex-Izquierdo
chore: pin minor version of aiohttp (#723)
1c0b1c8 
Yesterday, 3.11 version of `aiohttp` was released with [breaking changes
](https://github.com/aio-libs/aiohttp/releases/tag/v3.11.0 ) which
breaks `aioresponses` library used for our mocks and as consequence some
of our tests are failing.
Ref: pnuckowski/aioresponses#262

Regardless of whether this is fixed in aioresponses, aiohttp can
introduce breaking changes in minor versions, so I pin it to the latest
tested version as this library is critical for the stability in some of
our features.

Signed-off-by: Alex <[email protected]>
@cdessez
Copy link

cdessez commented Nov 15, 2024

today will upload, first need to fix some issues that occur while uploading to pypi :/ stay tuned

Ok, thanks a lot, @pnuckowski. :) 🙏
It's also less pressing now since aiohttp published 3.13.1 to also fix the backwards compatibility issue on their side.

@potiuk
Copy link

potiuk commented Nov 15, 2024 •
edited
Loading

Thanks @pnuckowski !

It's also less pressing now since aiohttp published 3.13.1 to also fix the backwards compatibility issue on their side.

But having it released might make them, to drop it back :)

@bdraco
Copy link
Contributor Author

bdraco commented Nov 15, 2024

Thanks @pnuckowski !

It's also less pressing now since aiohttp published 3.13.1 to also fix the backwards compatibility issue on their side.

But having it released might make them, to drop it back :)

Likely won't get dropped until 4.x (if ever) so no need to worry about that.

@pnuckowski
Copy link
Owner

released as 0.7.7

MoritzWeber0 added a commit to DSD-DBS/capella-collab-manager that referenced this pull request Nov 17, 2024
@MoritzWeber0
chore: Update aiohttp to latest version
472f6d0 
The underlying issue has been solved:
pnuckowski/aioresponses#262
@MoritzWeber0 MoritzWeber0 mentioned this pull request Nov 17, 2024
Merged
zkayyali812 pushed a commit to ansible/ansible-rulebook that referenced this pull request Dec 9, 2024
@Alex-Izquierdo @zkayyali812
chore: pin minor version of aiohttp (#723)
60fe2d2 
Yesterday, 3.11 version of `aiohttp` was released with [breaking changes
](https://github.com/aio-libs/aiohttp/releases/tag/v3.11.0 ) which
breaks `aioresponses` library used for our mocks and as consequence some
of our tests are failing.
Ref: pnuckowski/aioresponses#262

Regardless of whether this is fixed in aioresponses, aiohttp can
introduce breaking changes in minor versions, so I pin it to the latest
tested version as this library is critical for the stability in some of
our features.

Signed-off-by: Alex <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skethineedi-vf skethineedi-vf skethineedi-vf approved these changes

@pnuckowski pnuckowski pnuckowski approved these changes

@cdessez cdessez cdessez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bdraco @potiuk @cdessez @pnuckowski @skethineedi-vf