Update WebSocket sender to avoid extra utf-8 decode/encode round-trip #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
commented
Nov 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #713 +/- ##
==========================================
+ Coverage 38.69% 38.71% +0.01%
==========================================
Files 15 15
Lines 1442 1444 +2
==========================================
+ Hits 558 559 +1
- Misses 884 885 +1 ☔ View full report in Codecov by Sentry. |
bieniu
approved these changes
Nov 14, 2024
thecode
approved these changes
Nov 14, 2024
chemelli74
approved these changes
Nov 14, 2024
|
No rush to release this. It can come in whenever we do another bump. |
|
Thanks for the 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #676