feat: integer repeat #237
feat: integer repeat #237
Conversation
aioresponses/core.py
Outdated
| @@ -471,6 +471,10 @@ async def match( | |||
|
|
|||
| if matcher.repeat is False: | |||
| del self._matches[key] | |||
| elif matcher.repeat == 2: | |||
There was a problem hiding this comment.
Because I meant repeat=1 to have the same effect as repeat=False. That is, I interpret the number of repetitions to include the first call. I guess an alternative would be to define the number of repetitions as the number after the first call.
That is, for repeat=5, either:
- respond 5 times with foo
- respond with foo, and also do that the next 5 times (so 6 in total)
The former seems more intuitive to me.
There was a problem hiding this comment.
The repeat=1 case was actually broken. I fixed it and added a test. I also elaborated on this matter in the main README.
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
|
This feature would be very much appreciated 👍 |
aioresponses/core.py
Outdated
| @@ -469,8 +469,12 @@ async def match( | |||
| else: | |||
| return None | |||
|
|
|||
| if matcher.repeat is False: | |||
| if matcher.repeat in (False, 1): | |||
There was a problem hiding this comment.
test are not working and this part is bugged.
when repeat is set to True the if statement does not work [True in (False, 1) returns True].
IMO we should have
if isinstance(matcher.repeat, bool):
if not matcher.repeat:
del self._matches[key]
else:
if matcher.repeat == 1:
del self._matches[key]
matcher.repeat -= 1There was a problem hiding this comment.
Great suggestion, much cleaner. I'll gladly fix it. Just give me a few days, please (got a project deadline).
Closes #234.