Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlexMeasures Client basic functionality #7

Merged
merged 61 commits into from
May 8, 2023
Merged

FlexMeasures Client basic functionality #7

merged 61 commits into from
May 8, 2023

Conversation

GustaafL
Copy link
Collaborator

@GustaafL GustaafL commented May 4, 2023

  • request function
  • authentication
  • polling requests
  • get assets
  • get sensors
  • post measurements
  • trigger schedule
  • get schedule
  • error handling

Please don't review script_guus.py. Print statements can be left in for now. It would be nice to keep bigger changes out and put them into issues or TODO's that can be branched from the dev branch

GustaafL and others added 30 commits April 19, 2023 14:47
feat(auth): first draft api auth
799e382 
Signed-off-by: GustaafL <[email protected]>
@victorgarcia98
Adding depedencies to run async tests and project dependencies such a…
393973d 
…s pandas. To run test, we can use TOX (pip install tox) and run tox

Signed-off-by: victor <[email protected]>
feat(auth): small changes and some test code
b73d050 
Signed-off-by: GustaafL <[email protected]>
feat(auth): small changes and some test code
e6e7589 
Signed-off-by: GustaafL <[email protected]>
@victorgarcia98
Testing aioresponses mock.
295dd15 
Signed-off-by: victor <[email protected]>
feat(auth): trying to merge
3f1135a 
Signed-off-by: GustaafL <[email protected]>
Merge remote-tracking branch 'origin/fm-api-client-dependencies' into…
47ae524 
… fm-api-client

merging working test
feat(measurements): post measurements test code
c94ff6a 
Signed-off-by: GustaafL <[email protected]>
@Flix6x
Remove skeleton files
295119d
@Flix6x
Fix tests
972b69a
@Flix6x
Remove unused caplog
2dfa94c
@Flix6x
Allow closing the client, which closes the session
8eec4b4
feat(scheduling): trigger and get schedule
87ec9bc 
Signed-off-by: GustaafL <[email protected]>
@Flix6x
Clean up call to post_measurements
9535dd8
@Flix6x
Fix return values
e06b670
@Flix6x
Move construction of headers into request function
f7bcdaa
@Flix6x
Add polling and test it
028da32
@Flix6x
Add polling timeout
f542112 
Signed-off-by: F.N. Claessen <[email protected]>
@Flix6x
Add max polling steps
96daed1 
Signed-off-by: F.N. Claessen <[email protected]>
feat(client): added tests and review changes
d1a0935 
Signed-off-by: GustaafL <[email protected]>
@Flix6x
Test polling timeout
ff35102 
Signed-off-by: F.N. Claessen <[email protected]>
@Flix6x
merge fm-api-client-scheduling-functions into add-polling
58d427c 
Signed-off-by: F.N. Claessen <[email protected]>
@Flix6x
get rid of hardcoded consumption price sensor
6212792 
Signed-off-by: F.N. Claessen <[email protected]>
@Flix6x
close client
0d19243 
Signed-off-by: F.N. Claessen <[email protected]>
@Flix6x
Move ssl to __init__
9fb8e87 
Signed-off-by: F.N. Claessen <[email protected]>
@Flix6x
Rename argument
9196092 
Signed-off-by: F.N. Claessen <[email protected]>
@Flix6x
Rename function and lambda params
96e8a20 
Signed-off-by: F.N. Claessen <[email protected]>
@Flix6x
black
742ddcc 
Signed-off-by: F.N. Claessen <[email protected]>
@Flix6x
flake8
609e335 
Signed-off-by: F.N. Claessen <[email protected]>
feat(client): add getting sensor and asset
002f9d0 
Signed-off-by: GustaafL <[email protected]>
@GustaafL
Copy link
Collaborator Author

GustaafL commented May 5, 2023

#2 (comment)

This one is still open from PR #2 , not sure what to do there

@GustaafL GustaafL requested a review from victorgarcia98 May 5, 2023 08:56
@GustaafL GustaafL requested a review from Flix6x May 8, 2023 10:03
GustaafL added 8 commits May 8, 2023 12:21
refactor(init): since python 3.9 is required remove check for python …
0eb27ec 
…version higher than 3.8

Signed-off-by: GustaafL <[email protected]>
refactor(pre-commit): flake and isort changes locally executed
a1d3e77 
Signed-off-by: GustaafL <[email protected]>
refactor(pre-commit): flake and isort changes locally executed
51881a2 
Signed-off-by: GustaafL <[email protected]>
fix(CI): turned off coveralls
123aafc 
Signed-off-by: GustaafL <[email protected]>
fix(CI): turned off coveralls completely
9d1c91f 
Signed-off-by: GustaafL <[email protected]>
fix(CI): turned off coveralls try 3
d743e15 
Signed-off-by: GustaafL <[email protected]>
fix(CI): revert coveralls turned off
2d1c8c5 
Signed-off-by: GustaafL <[email protected]>
fix(CI): new coveralls turn off test
30572ca 
Signed-off-by: GustaafL <[email protected]>
victorgarcia98
victorgarcia98 requested changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@victorgarcia98 victorgarcia98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the changes and opening the Issues. Good stuff.

I think it's almost done, just a few minor type hints that might be improved.

src/flexmeasures_client/client.py Outdated Show resolved Hide resolved
src/flexmeasures_client/client.py Outdated Show resolved Hide resolved
src/flexmeasures_client/client.py Show resolved Hide resolved
src/flexmeasures_client/client.py Outdated Show resolved Hide resolved
src/flexmeasures_client/client.py Outdated Show resolved Hide resolved
src/flexmeasures_client/client.py Outdated Show resolved Hide resolved
tests/test_client.py Show resolved Hide resolved
tests/test_client.py Show resolved Hide resolved
Flix6x
Flix6x approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looking forward to using this.

Please just test whether test__init__ still succeeds after removing line 18 from test_client.py (which sets the api_version).

src/flexmeasures_client/client.py Show resolved Hide resolved
src/flexmeasures_client/constants.py Outdated Show resolved Hide resolved
tests/test_client.py Show resolved Hide resolved
src/flexmeasures_client/response_handling.py Show resolved Hide resolved
tests/test_client.py Show resolved Hide resolved
@Flix6x Flix6x mentioned this pull request May 8, 2023
Closed
3 tasks
@GustaafL GustaafL mentioned this pull request May 8, 2023
Closed
@GustaafL GustaafL mentioned this pull request May 8, 2023
Open
@GustaafL GustaafL requested a review from victorgarcia98 May 8, 2023 15:04
@victorgarcia98 victorgarcia98 self-requested a review May 8, 2023 15:04
victorgarcia98
victorgarcia98 approved these changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@victorgarcia98 victorgarcia98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Looking forward to use it in the S2 Handler and other places, of course.

@GustaafL GustaafL merged commit e5cc684 into dev May 8, 2023
@GustaafL GustaafL deleted the test-dev-client-errors branch May 8, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorgarcia98 victorgarcia98 victorgarcia98 approved these changes

@Flix6x Flix6x Flix6x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GustaafL @Flix6x @victorgarcia98