Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create script to update geneds #91

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Create script to update geneds #91

wants to merge 35 commits into from

Conversation

nsandler1
Copy link
Member

@nsandler1 nsandler1 commented Feb 7, 2023 •
edited by tybug
Loading

Closes #11

creates a management command to update geneds

@nsandler1 nsandler1 changed the title Gened script Create script to update geneds by semester Feb 7, 2023
@nsandler1 nsandler1 added the blocked Awaiting changes elsewhere label Feb 7, 2023
@nsandler1 nsandler1 mentioned this pull request Feb 7, 2023
Open
2 tasks
@nsandler1 nsandler1 removed the blocked Awaiting changes elsewhere label Feb 7, 2023
@tybug tybug mentioned this pull request Feb 20, 2023
Merged
@tybug
Copy link
Contributor

tybug commented Feb 20, 2023 •
edited
Loading

Does this command have to accept a semester? I was envisioning that this command simply defaulted to the latest semester. I can't think of any use case where we would want to use gened data from an old semester instead of the latest data available for all courses.

Hitting umdio without a semester parameter pulls the data for the most recent semester that course was taken.

@nsandler1 nsandler1 mentioned this pull request Feb 20, 2023
Closed
@nsandler1
Copy link
Member Author

nsandler1 commented Feb 20, 2023 •
edited
Loading

Does this command have to accept a semester? I was envisioning that this command simply defaulted to the latest semester. I can't think of any use case where we would want to use gened data from an old semester instead of the latest data available for all courses.

Hitting umdio without a semester parameter pulls the data for the most recent semester that course was taken.

I guess the semester argument doesn't need to be required but I want to keep it optional in case we want to run the script for a different semester

@nsandler1
Copy link
Member Author

This pr is ready for review again

@nsandler1 nsandler1 changed the title Create script to update geneds by semester Create script to update geneds Mar 8, 2023
@nsandler1 nsandler1 mentioned this pull request Mar 27, 2023
Open
1 task
@nsandler1
Copy link
Member Author

Blocked until semester comparator of umdio api is fixed

@nsandler1 nsandler1 added the blocked Awaiting changes elsewhere label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tybug tybug tybug left review comments

Assignees
No one assigned
Labels
blocked Awaiting changes elsewhere
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update geneds
2 participants
@nsandler1 @tybug