Course schema changes to support new gened format #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 7, 2023
tybug
approved these changes
Feb 20, 2023
Comment on lines
+222
to
+234
| def gened_str(self): | ||
| gened_str = [] | ||
| for item in self.geneds: | ||
| add_parens = len(item) > 1 and len(self.geneds) > 1 | ||
| and_str = "(" if add_parens else "" | ||
| and_str += " and ".join(item) | ||
| and_str += ")" if add_parens else "" | ||
|
|
||
| # special umdio case. EX: https://api.umd.io/v1/courses/CHEM131 | ||
| and_str = and_str.replace("|", " if taken with ") | ||
| gened_str.append(and_str) | ||
| return " or ".join(gened_str) | ||
|
|
There was a problem hiding this comment.
nit: this change would have fit better in #91.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the course schema to include a geneds field that will be used to store the gened string from umdio.
NOTE: this pr will break anything else on the site that uses geneds. #92 updates the frontend where necessary.