-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIP 56 mapping changes #1289
NIP 56 mapping changes #1289
Changes from all commits
1c7ea5a
fdc2a8d
cf56418
563710d
52cc2a5
cd865bf
76f6b2e
8e90fca
2f858b9
df298ab
cbcc7c8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,7 +42,7 @@ struct ReportCategory: Identifiable, Equatable { | |
} | ||
|
||
enum NIP56Code: String { | ||
case nudity, profanity, illegal, spam, impersonation, other | ||
case nudity, malware, profanity, illegal, spam, impersonation, other | ||
} | ||
|
||
enum ReportCategoryType { | ||
|
@@ -61,7 +61,7 @@ enum ReportCategoryType { | |
static let harassment = ReportCategory( | ||
name: .moderation.harassment, | ||
code: "IL-har", | ||
nip56Code: .other | ||
nip56Code: .profanity | ||
) | ||
|
||
static let intoleranceAndHate = ReportCategory( | ||
|
@@ -89,7 +89,13 @@ enum ReportCategoryType { | |
static let nsfw = ReportCategory( | ||
name: .moderation.nsfw, | ||
code: "NW", | ||
nip56Code: .other | ||
nip56Code: .nudity | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While NSFW content may contain nudity, it's not the only option. According to Wikipedia:
I don't know how NIP-56 is typically used, so maybe There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @setch-l what about changing the NSFW acronym to something else? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nudity and sexual content is fine. We don't have anything for violence so then it simply results in expanding the categories once again. The goal of this work was in the moment to not have to make people think. More than 7 categories requires people to think too much. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤔 why are we bending ourselves around what is in NIP-56? We know it doesn't work for us, that's why we have made our own categories. So let's keep NSFW as a category, it's very broadly useful, and continue mapping it to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see. I've read the ticket comments now. I didn't realize we were completely overhauling the categories. This PR is still publishing events with NIP-69 labels, right? Are you planning to remove those in another PR? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not anymore, this was covered in cd865bf |
||
) | ||
|
||
static let impersonation = ReportCategory( | ||
name: .moderation.impersonation, | ||
code: "IM", | ||
nip56Code: .impersonation | ||
) | ||
|
||
static let nudity = ReportCategory( | ||
|
@@ -138,6 +144,7 @@ extension ReportCategoryType { | |
ReportCategoryType.likelyToCauseHarm, | ||
ReportCategoryType.harassment, | ||
ReportCategoryType.intoleranceAndHate, | ||
ReportCategoryType.impersonation, | ||
ReportCategoryType.illegal, | ||
ReportCategoryType.nsfw, | ||
ReportCategoryType.nudity, | ||
|
@@ -150,8 +157,9 @@ extension ReportCategoryType { | |
static let authorCategories = [ | ||
ReportCategoryType.spam, | ||
ReportCategoryType.harassment, | ||
ReportCategoryType.nsfw, | ||
ReportCategoryType.nudity, | ||
ReportCategoryType.illegal, | ||
ReportCategoryType.impersonation, | ||
ReportCategoryType.other, | ||
] | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep this one as
other
also. harassment != profanity and in my opinion it's better to be vague and say "other" than to be wrong. We've seen people get upset when they feel like their content has been labeled wrongly and this will only increase that.