NIP 56 mapping changes #1289
NIP 56 mapping changes #1289
Conversation
dcadenas
requested review from
mplorentz,
martindsq and
joshuatbrown
as code owners
| @@ -89,7 +89,13 @@ enum ReportCategoryType { | |||
| static let nsfw = ReportCategory( | |||
| name: .moderation.nsfw, | |||
| code: "NW", | |||
| nip56Code: .other | |||
| nip56Code: .nudity | |||
There was a problem hiding this comment.
While NSFW content may contain nudity, it's not the only option. According to Wikipedia:
The marked content may contain graphic violence, pornography, profanity, nudity, slurs or other potentially disturbing subject matter.
I don't know how NIP-56 is typically used, so maybe .nudity is better than .other for NSFW, but I want to be sure we use the best option here.
There was a problem hiding this comment.
@setch-l what about changing the NSFW acronym to something else?
There was a problem hiding this comment.
Nudity and sexual content is fine.
We don't have anything for violence so then it simply results in expanding the categories once again. The goal of this work was in the moment to not have to make people think. More than 7 categories requires people to think too much.
There was a problem hiding this comment.
🤔 why are we bending ourselves around what is in NIP-56? We know it doesn't work for us, that's why we have made our own categories. So let's keep NSFW as a category, it's very broadly useful, and continue mapping it to other for clients that only support NIP-56?
There was a problem hiding this comment.
If we use other we need to get back to use NIP-69 to get the specifics in addition to NIP-56 as we were doing before these changes. If we do that, then the buttons in the Slack channel should be NIP-69 categories, not NIP-56. Not all of what NIP-69 offers but only the same subset available through the app.
There was a problem hiding this comment.
I see. I've read the ticket comments now. I didn't realize we were completely overhauling the categories. This PR is still publishing events with NIP-69 labels, right? Are you planning to remove those in another PR?
There was a problem hiding this comment.
Not anymore, this was covered in cd865bf
| @@ -61,7 +61,7 @@ enum ReportCategoryType { | |||
| static let harassment = ReportCategory( | |||
| name: .moderation.harassment, | |||
| code: "IL-har", | |||
| nip56Code: .other | |||
| nip56Code: .profanity | |||
There was a problem hiding this comment.
I think we should keep this one as other also. harassment != profanity and in my opinion it's better to be vague and say "other" than to be wrong. We've seen people get upset when they feel like their content has been labeled wrongly and this will only increase that.
|
@mplorentz @dcadenas @joshuatbrown - The entire point of this work was to remove NIP69 categories across the board. There are too many of them for the type of content moderation we offer today. In the future those categories may be useful. Daniel and I made a plan. @dcadenas - let's stick to our original plan. If someone tags something NSFW and falls into another category - I don't care. I also think NSFW is less confrontation for those whose content is being tagged. |
@setch-l I'm confused, should we map NSFW to |
|
To nudity |
Issues covered
#1247
Description
To correctly map with the new changes for the manual moderation channel in Slack we are tweaking how we map some categories and adding
impersonationHow to test
Send To Noscategories appear in the Slack channel messageScreenshots/Video