Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple author affiliations #417

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

GaziYucel
Copy link

@GaziYucel GaziYucel commented Sep 27, 2024

@GaziYucel GaziYucel changed the title Author Affiliations (work in progress) Multiple author affiliations Oct 9, 2024
@GaziYucel
Copy link
Author

I am waiting for a variant of the FieldBaseSuggest.vue component. After this, this PR can be wrapped up.

@GaziYucel
Copy link
Author

I have done a force push, because there was an error rebasing a couple of days ago. The PR is clean and up to date again.

@GaziYucel
Copy link
Author

GaziYucel commented Nov 20, 2024

Hi @jardakotesovec,

I have implemented everything we discussed and all seems to work.

There are some notes:

  • you mentioned that Blessie was working on a variant of FieldBaseSuggest.vue which I can use
    Add customization support for FieldBaseAutosuggest options pkp-lib#10624
  • I have used <input type="text" for input fields. It would be better to have a very simple Vue component to use. This would have the following advantages:
    • less clutter and cleaner code
    • better accessibility
  • error handling
    • this is not implemented a la OJS
    • the check I do: there should be a ROR or at least one name and the name should be the primary locale
    • if this is not true, I disable the 'Add' button
    • saving the form is still enabled
  • UI design
    • @Devika008 used a pie to show how many translations there are. I couldn't do this, because there is no component for this. I implemented "MultilingualProgress" instead
    • Devika placed the text/link "# of # translations completed" below the input fields. I moved this to above, because this makes the interface less jumpy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants