Skip to content

Commit

Permalink
currentValue getter/setter
Browse files Browse the repository at this point in the history
refactoring for better understanding
documentation properties, variables, functions
  • Loading branch information
GaziYucel committed Nov 27, 2024
1 parent 075e88a commit bcb04a5
Show file tree
Hide file tree
Showing 5 changed files with 271 additions and 145 deletions.
5 changes: 3 additions & 2 deletions public/globals.js
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ window.pkp = {
'article.metadata': 'Metadata',
'author.users.contributor.principalContact': 'Primary Contact',
'author.users.contributor.setPrincipalContact': 'Set Primary Contact',
'common.add': 'Add',
'common.addCCBCC': 'Add CC/BCC',
'common.assign': 'Assign',
'common.attachFiles': 'Attach Files',
Expand Down Expand Up @@ -755,11 +756,11 @@ window.pkp = {
'user.affiliations.translationDeleteActionLabel': 'Remove institution',
'user.affiliations.translationActionsAriaLabel': 'Click to edit or delete',
'user.affiliations.translationsAllAvailable': 'All translations available',
'user.affiliations.translationsSomeAvailable': '{$translated} of {$total} languages completed',
'user.affiliations.translationsSomeAvailable': '{$count} of {$total} languages completed',
'user.affiliations.typeTranslationNameInLanguageLabel': 'Type the institute name in {$language}',
'user.affiliations.translationNameInLanguage': 'Institute name in {$language}',
'user.affiliations.deleteModal.title': 'Are you sure?',
'user.affiliations.deleteModal.message': 'The institution <strong>{$institution}</strong> will be deleted.',
'user.affiliations.deleteModal.message': 'The affiliation <strong>{$affiliation}</strong> will be deleted.',
'user.affiliations.searchPhraseLabel': 'Type the institute name in {$language}',
'user.affiliations.searchPhraseNothingFound': 'Your search phrase could not be found',
'user.affiliations.primaryLocaleRequired': 'The primary language {$primaryLocale} is required',
Expand Down
8 changes: 4 additions & 4 deletions src/components/Form/fields/FieldAffiliations.stories.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import FieldAffiliations from './FieldAffiliations.vue';
import FieldAffiliationsMock from '@/components/Form/mocks/field-affiliations';
import {http, HttpResponse} from "msw";
import {http, HttpResponse} from 'msw';

const args = {...FieldAffiliationsMock};

Expand All @@ -14,7 +14,7 @@ export default {
http.get(
'https://mock/index.php/publicknowledge/api/v1/rors/?searchPhrase=Simon+Fraser+University',
async () => {
return HttpResponse.json(args.apiResponse);
return HttpResponse.json(args.searchResults);
},
),
],
Expand All @@ -23,10 +23,10 @@ export default {
render: (args) => ({
components: {FieldAffiliations},
setup() {
return {args}
return {args};
},
template: `
<FieldAffiliations v-bind="args"/>`
<FieldAffiliations v-bind="args"/>`,
}),
decorators: [
() => ({
Expand Down
Loading

0 comments on commit bcb04a5

Please sign in to comment.