Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Added translations #119

Merged
merged 10 commits into from
Mar 13, 2024
Merged

[Feature] Added translations #119

merged 10 commits into from
Mar 13, 2024

Conversation

Corepex
Copy link
Contributor

@Corepex Corepex commented Mar 8, 2024

Changes in this pull request

Partly Resolves #106
Blocked By: pimcore/studio-backend-bundle#17

Additional info

  • Added loader for translations
  • added config for translations endpoint

TODOs

  • create a rough wrapper for the application (showing a loading state)
  • add useEffect hook to call the translation endpoint
  • add translations to i18n
  • add custom translation domain for the studio-ui bundle
  • add translation files to repo (check)

@Corepex Corepex self-assigned this Mar 8, 2024
Copy link

github-actions bot commented Mar 12, 2024

Qodana for PHP

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Corepex added 3 commits March 12, 2024 11:13
# Conflicts:
#	assets/js/src/components/toolbar/toolbar.tsx
#	assets/js/src/modules/asset/editor-tabs/index.tsx
#	public/build/entrypoints.json
#	public/build/manifest.json
@Corepex Corepex marked this pull request as ready for review March 12, 2024 14:16
@Corepex Corepex merged commit f0e6335 into 1.x Mar 13, 2024
14 checks passed
@Corepex Corepex deleted the translations branch March 13, 2024 09:37
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translations Phase 1
2 participants