Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom translation domain #17

Merged
merged 6 commits into from
Mar 13, 2024
Merged

Custom translation domain #17

merged 6 commits into from
Mar 13, 2024

Conversation

Corepex
Copy link
Contributor

@Corepex Corepex commented Mar 12, 2024

Changes in this pull request

Partly Resolves pimcore/studio-ui-bundle#106
Related to: pimcore/studio-ui-bundle#119

Additional info

@Corepex Corepex self-assigned this Mar 12, 2024
@Corepex Corepex requested a review from mattamon March 12, 2024 10:36
src/Installer.php Outdated Show resolved Hide resolved
@Corepex Corepex requested a review from mattamon March 13, 2024 08:56
Copy link
Contributor

@mattamon mattamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Corepex Corepex merged commit 3c3359e into 0.x Mar 13, 2024
5 checks passed
@Corepex Corepex deleted the custom_translation_domain branch March 13, 2024 09:28
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants