Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Upgrade dependencies #440

Merged
merged 3 commits into from
Dec 2, 2024
Merged

[Task] Upgrade dependencies #440

merged 3 commits into from
Dec 2, 2024

Conversation

mattamon
Copy link
Contributor

No description provided.

@blankse
Copy link
Contributor

blankse commented Nov 26, 2024

@mattamon I think you can cleanup following things:

  • Remove require_admin_bundle options in matrix
  • Remove REQUIRE_ADMIN_BUNDLE env in "Setup Pimcore environment" steps
  • Remove Lines 16-22 in .github/ci/scripts/setup-pimcore-environment.sh
  • Remove file .github/ci/files/security.yaml

@mattamon
Copy link
Contributor Author

@mattamon I think you can cleanup following things:

  • Remove require_admin_bundle options in matrix
  • Remove REQUIRE_ADMIN_BUNDLE env in "Setup Pimcore environment" steps
  • Remove Lines 16-22 in .github/ci/scripts/setup-pimcore-environment.sh
  • Remove file .github/ci/files/security.yaml

yeah I am on it already, wanted to check the tests first

@mattamon mattamon merged commit 336d65f into 1.x Dec 2, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
@mattamon mattamon deleted the upgrade-dependencies branch December 2, 2024 16:09
@mattamon mattamon linked an issue Dec 10, 2024 that may be closed by this pull request
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Upgrade Dependencies
2 participants