Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PowerSGDCompressor #27 #47

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Add PowerSGDCompressor #27 #47

wants to merge 13 commits into from

Conversation

huangrh99
Copy link

No description provided.

@zhisbug zhisbug requested a review from sonicxml October 26, 2020 15:44
sonicxml
sonicxml suggested changes Oct 27, 2020
View reviewed changes
autodist/kernel/synchronization/compressor.py Show resolved Hide resolved
autodist/kernel/synchronization/compressor.py Show resolved Hide resolved
autodist/kernel/synchronization/compressor.py Outdated Show resolved Hide resolved
autodist/kernel/synchronization/compressor.py Outdated Show resolved Hide resolved
@huangrh99
lintering
c774e46 
* linter

* update import

* delete the commented code

* synchronize the compressor at first
@huangrh99
Revert "lintering"
835ff73 
This reverts commit c774e46.
@huangrh99
Update PowerSGDCompressor
c228567
@huangrh99
Add random seed for initialization of compressor
508dc32
sonicxml
sonicxml previously approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@sonicxml sonicxml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as long as it's been tested

@zhisbug
Copy link
Contributor

zhisbug commented Nov 2, 2020

@ezra-h CI still fails, please check & fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhisbug zhisbug zhisbug left review comments

@sonicxml sonicxml sonicxml left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@huangrh99 huangrh99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huangrh99 @zhisbug @sonicxml