Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary patch to 'Unsupported event' #422

Closed
wants to merge 3 commits into from
Closed

Conversation

diamondburned
Copy link
Contributor

Unsupported events are now silenced. Fixes #421.

When #319 is merged, all events will be logged fully again.

@a-urth
Copy link
Contributor

a-urth commented Dec 12, 2019

@diamondburned thats not exactly what i meant, sorry for misunderstanding.
So commenting handling unknown events is definitely not what we need.
I'm not sure whether we need those 2 events at all or they can be just log messages. First can be clarified with @iwasaki-kenta and @claudiucelfilip

But how do you think much time it will take to add ws support (parsing mainly) for those two events? Thats in case we actually need them to be send over ws. Otherwise i guess it can be changed to logging pretty fast, right?

@diamondburned
Copy link
Contributor Author

@diamondburned thats not exactly what i meant, sorry for misunderstanding.
So commenting handling unknown events is definitely not what we need.
I'm not sure whether we need those 2 events at all or they can be just log messages. First can be clarified with @iwasaki-kenta and @claudiucelfilip

But how do you think much time it will take to add ws support (parsing mainly) for those two events? Thats in case we actually need them to be send over ws. Otherwise i guess it can be changed to logging pretty fast, right?

Changing to logging is simple, it's just changing log.Event() to log.Node(). However, the current logging structure is ideally done over WS, so it should either be an actual event, or it should be a debugging event (which doesn't go over WS afaik).

That said, if these 2 events are needed over WS, I could do that.

@a-urth
Copy link
Contributor

a-urth commented Dec 13, 2019

@diamondburned so those events are both used in frontend, so we need to support them.

@diamondburned
Copy link
Contributor Author

@diamondburned so those events are both used in frontend, so we need to support them.

It's added now.

@@ -129,6 +129,7 @@ func (c *CollapseResultsLogger) Log(results *collapseResults) {
func (c *CollapseResultsLogger) addTx(mod, event []byte,
timestamp time.Time, tag int,
txID []byte, sender []byte, logError error) {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this new line please

@a-urth
Copy link
Contributor

a-urth commented Dec 16, 2019

@diamondburned and merge master to this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WS events errors.
2 participants