-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary patch to 'Unsupported event' #422
Conversation
@diamondburned thats not exactly what i meant, sorry for misunderstanding. But how do you think much time it will take to add ws support (parsing mainly) for those two events? Thats in case we actually need them to be send over ws. Otherwise i guess it can be changed to logging pretty fast, right? |
Changing to logging is simple, it's just changing That said, if these 2 events are needed over WS, I could do that. |
@diamondburned so those events are both used in frontend, so we need to support them. |
It's added now. |
@@ -129,6 +129,7 @@ func (c *CollapseResultsLogger) Log(results *collapseResults) { | |||
func (c *CollapseResultsLogger) addTx(mod, event []byte, | |||
timestamp time.Time, tag int, | |||
txID []byte, sender []byte, logError error) { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this new line please
@diamondburned and merge master to this branch |
Unsupported events are now silenced. Fixes #421.
When #319 is merged, all events will be logged fully again.