wctl refactoring: Concrete data structures and code cleanup #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wavelet: remove gossip mechanism * wavelet: fix dependencies
* all: remove transaction creator. replace it with transaction sender * all: rename Sender Signature to Signature * ledger, collapse, contract, tx: WIP add mempool and blocks. update collapseTransactions * ledger, genesis, db, block: replace rounds with blocks * block: make block implements snowball.Identifiable * all: implement query, modify snowball, update protocol.
* wavelet: remove DownloadTx RPC and SyncTransactions method * wavelet, conf: use bloom filter for detecting missing tx * ledger: add existing txs in graph to bloom filter * ledger: always add tx to bloom filter * ledger: add delay between pulls
# Conflicts: # ledger.go # mempool.go
# Conflicts: # protocol.go
# Conflicts: # protocol.go
…e rounds data structure and rename any references from rounds to blocks ledger: add todos for block proposal, and fix build errors for any logs genesis, block, ledger: add todos for merkle root derivation, and derive initial root for the genesis block sys, config, cmd/wavelet: rename SyncIfRoundsDifferBy to SyncIfBlockIndicesDifferBy, and RewardWithdrawalsRoundLimit to RewardWithdrawalsBlockLimit
# Conflicts: # block.go # common.go # conf/conf.go # genesis.go # ledger.go # protocol.go # vote.go
diamondburned
added
enhancement
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
diamondburned
changed the title
a-urth
reviewed
Jan 13, 2020
| ev.Msg("Updated account " + updated + ".") | ||
| } | ||
|
|
||
| // yes, I know this is a terrible function name, it can't be helped |
There was a problem hiding this comment.
i don't think this comment is necessary.
| } | ||
|
|
||
| // yes, I know this is a terrible function name, it can't be helped | ||
| func unmarshalAccountIDandUint64(v *fastjson.Value, id AccountID, ukey string, u *uint64) error { |
There was a problem hiding this comment.
it definitely should be renamed at least to something containing amount instead of uint64.
also maybe 2 separate functions might be used - one for account and another one for amount? even though there will be two function calls, intention and naming will be much cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Known breaking changes:
num_accounts_in_storeis removed, asnum_accountshas the same value.Other minor changes:
Websocket ignores all events belowinfoledger.gochanges).waveletandapipackages. No more manually updating fields inwctl,cliand elsewhere.This PR solves #422.
! This PR is untested !The PR now passes tests.