[bugfix] Change Bash regex for engine labels #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-rister
requested changes
Oct 23, 2024
rafaelfolco
force-pushed
the
fix-regex
branch
from
dea56ad to
5f09041
Compare
k-rister
requested changes
Oct 23, 2024
rafaelfolco
force-pushed
the
fix-regex
branch
from
5f09041 to
f90a1d7
Compare
k-rister
previously approved these changes
Oct 23, 2024
k-rister
force-pushed
the
fix-regex
branch
2 times, most recently
from
d6e4204 to
41b39de
Compare
|
Something is wrong with the new regex/logic. Need more debugging... |
rafaelfolco
force-pushed
the
fix-regex
branch
2 times, most recently
from
b53f3db to
6daa2b1
Compare
rafaelfolco
force-pushed
the
fix-regex
branch
3 times, most recently
from
744b125 to
3ddef1a
Compare
It is now capable of capturing a profiler name with dashes in the middle of the string - e.g. rt-trace-bpf.
rafaelfolco
force-pushed
the
fix-regex
branch
from
3ddef1a to
f36c988
Compare
k-rister
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now capable of capturing a profiler name with dashes in the middle of the string - e.g. rt-trace-bpf.