Skip to content

Commit

Permalink
[bugfix] Change Bash regex for engine labels
Browse files Browse the repository at this point in the history
It is now capable of capturing a profiler name with dashes in the
middle of the string - e.g. rt-trace-bpf.
  • Loading branch information
rafaelfolco authored and k-rister committed Oct 24, 2024
1 parent 96121a6 commit d6e4204
Showing 1 changed file with 13 additions and 7 deletions.
20 changes: 13 additions & 7 deletions engine/engine-script-library
Original file line number Diff line number Diff line change
Expand Up @@ -305,14 +305,20 @@ function validate_core_env() {
if [ -z "$cs_label" ]; then
exit_error "The client/server label (--cs-label) was not defined"
fi
# profiler-remotehost-1-sysstat-1
regex1='^profiler-\w+-\d+-\w+-\d+$'
# client-1
regex2='^\w+-\d+$'
if echo $cs_label | grep -q -P $regex1; then
export tool_name=`echo $cs_label | awk -F- '{print $4}'`
# (rfolco): regex 101
# ^profiler- ensures the string starts with profiler-.
# ([a-zA-Z]+) captures one or more lowercase/uppercase letters for the second part.
# ([0-9]+) captures one or more digits for the third part.
# ([a-zA-Z_-]+) captures one or more lowercase/uppercase letters, underscores, or dashes for the fourth part.
# ([0-9]+)$ ensures the string ends with a number after the last part.
# e.g. profiler-remotehost-1-sysstat-1 or profiler-remotehost-1-rt-trace-bpf-1
regex1='^profiler-([a-zA-Z]+)-([0-9]+)-([a-zA-Z_-]+)-([0-9]+)$'
# client-1 or server-1
regex2='^([a-zA-Z]+)-([0-9]+)$'
if [[ $cs_label =~ $regex1 ]]; then
export tool_name=`echo $cs_label | sed -E 's/^[^-]+-[^-]+-[0-9]+-(.+)-[0-9]+$/\1/'`
echo "engine-label \"$cs_label\" is valid and runs this tool: $tool_name"
elif echo $cs_label | grep -q -P $regex2; then
elif [[ $cs_label =~ $regex2 ]]; then
echo "engine-label \"$cs_label\" is valid"
else
exit_error 'cs_label "'$cs_label'" is not valid'
Expand Down

0 comments on commit d6e4204

Please sign in to comment.